From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E41FC4332E for ; Mon, 15 Mar 2021 08:35:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6F3364EBD for ; Mon, 15 Mar 2021 08:35:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229766AbhCOIeo (ORCPT ); Mon, 15 Mar 2021 04:34:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229614AbhCOIeV (ORCPT ); Mon, 15 Mar 2021 04:34:21 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6304BC061574 for ; Mon, 15 Mar 2021 01:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WP1+kEkpWwIMY5F3rN8QbOxecZIRGyIBEVF6fseXUyc=; b=oG/MR5mHInuZm06IaaEF9C3ooY 1EHe6COHJvwunM+nF3iBhVqu5Cp3giiLFjhumRzLED+yCcBzRf8CqOGcTDhowPulgv9wqfrhAbhTl IUtjfdPtJeQgtVBz9SIlAW6DcQC1y5ekrvptOok+rLbRC9kjlN5r43EAo2JTd2I6weegO0jqVIOo3 kmZ084P+mh9/6FZGZzkxv3t6l0Fz502+QECdEGhEC2A/6rZ9ob+Byuu/3YA3BwAKc28IR0r847XLd npIGe2Pp29DVAout1jP7vl/y+FwGC6A7ipZqV1wbnhxeTZ7qBt5Aip+fgZ4+6pwJ41e3F9q/CsmFW +2/vluhA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lLifa-00HS2O-Rg; Mon, 15 Mar 2021 08:33:50 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 478AA303205; Mon, 15 Mar 2021 09:33:45 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 2B29623CC228C; Mon, 15 Mar 2021 09:33:45 +0100 (CET) Date: Mon, 15 Mar 2021 09:33:45 +0100 From: Peter Zijlstra To: Linus Torvalds Cc: Thomas Gleixner , Linux Kernel Mailing List , the arch/x86 maintainers Subject: Re: [GIT pull] locking/urgent for v5.12-rc3 Message-ID: References: <161573639668.27979.17827928369874291298.tglx@nanos> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 14, 2021 at 01:15:25PM -0700, Linus Torvalds wrote: > On Sun, Mar 14, 2021 at 8:40 AM Thomas Gleixner wrote: > > > > - A fix for the static_call mechanism so it handles unaligned > > addresses correctly. > > I'm not disputing the fix in any way, but why weren't the relocation > info and function start addresses mutually aligned? > > Are we perhaps missing some .align directive somewhere? > > Or am I missing something? So I considered looking into that, but since carrying the flag on the absolute address is always correct I figured it was the more robust fix. I suppose I can try and figure out where alignment went wobbly.