From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 905D6C433DB for ; Fri, 5 Mar 2021 00:05:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6323764FF9 for ; Fri, 5 Mar 2021 00:05:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230439AbhCEAFz (ORCPT ); Thu, 4 Mar 2021 19:05:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229957AbhCEAFy (ORCPT ); Thu, 4 Mar 2021 19:05:54 -0500 Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FC27C061574 for ; Thu, 4 Mar 2021 16:05:52 -0800 (PST) Received: by mail-oi1-x234.google.com with SMTP id j1so516637oiw.3 for ; Thu, 04 Mar 2021 16:05:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3rn+KCEOmOu8NeH8O3e1dlLQ9odBWFmrFywzdTHe3Q0=; b=j/02VbP9jX5VnNiqlvDxU4Zq+czyYuekx2+AFq60l+s+mFb+M+honHGH71ftng6ipW vdWMHwWGo3pLU0pW4Yen46JneheffHWagGaozlpYhScNis9HE6l+Bennm5/Fbd7lNehS UrrU6WW46887IJWydbjFVNc2Pxg10QmtU8KNdVLxirscyPzlTSmxUNeA2RS7LunGZPGd u1DcT6C/gmZkfHc3rYXrEpse9H2rY0ow64eyGe1VbZBeQYJdA8tldQNOB5uWcpFKLUFm OFSmopJhF7KzpR1zDfcvqW3CE98jYXixHcpQFdW6bVpzIk2evB1q/YplZgbfqgJhPqAv devQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3rn+KCEOmOu8NeH8O3e1dlLQ9odBWFmrFywzdTHe3Q0=; b=ku4ywcUxTDNMwJF++baMJAtlXSVfbWfmmVHpVgoxmzxsh0syfocURSFEV3dbFj+yHB uyOzpVZyG0B4kCZyljsFVbELIS0YgU7HpNNIVIquHzfJ5z6MAgBnqtpWojL3UXxY14Po ZYnfWW9h5LeZAgPBue+DDbgYRs+q5t7F7BauvQV6VBuZvGlF8kVTmeaQQBizGLVFjhCc 0JHK0RPhsVL3Jg4lDysmOtOr5ow35dn4gdcr4OOfvJtS7T+vvgKGG35pFU+2XSOFEnjw kk60x+gLhFjsyfhTvuGxaZ9baRco2rZwHFe0nIBXQpiAZ8oj8Q0zmlX7nDJSiudyS2KN 21Jg== X-Gm-Message-State: AOAM530zGEFiZH3mlL8W7/fZ35LHyB0SiLA9akFRVk/5PguWEoOYGXUj 0p/aOm4hstIVvZHYutKY9wKEr/66LS0mqg== X-Google-Smtp-Source: ABdhPJwEPJzjaCRNvCQ/xMDgfK7sOeaLw/RhUB7Khaaf0s4n4hopJMtRQH78ob4WfY1vbzMJpZ1S1Q== X-Received: by 2002:aca:7514:: with SMTP id q20mr4996099oic.86.1614902751942; Thu, 04 Mar 2021 16:05:51 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id p67sm170678oih.21.2021.03.04.16.05.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 16:05:51 -0800 (PST) Date: Thu, 4 Mar 2021 18:05:49 -0600 From: Bjorn Andersson To: Jonathan Marek Cc: linux-arm-msm@vger.kernel.org, Andy Gross , Linus Walleij , Srinivas Kandagatla , "open list:PIN CONTROL SUBSYSTEM" , open list Subject: Re: [PATCH] pinctrl: qcom: lpass lpi: use default pullup/strength values Message-ID: References: <20210304194816.3843-1-jonathan@marek.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210304194816.3843-1-jonathan@marek.ca> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 04 Mar 13:48 CST 2021, Jonathan Marek wrote: > If these fields are not set in dts, the driver will use these variables > uninitialized to set the fields. Not only will it set garbage values for > these fields, but it can overflow into other fields and break those. > > In the current sm8250 dts, the dmic01 entries do not have a pullup setting, > and might not work without this change. > Perhaps you didn't see it, but Dan reported this a few days back. So unless you object I would suggest that we include: Reported-by: kernel test robot Reported-by: Dan Carpenter Reviewed-by: Bjorn Andersson Regards, Bjorn > Fixes: 6e261d1090d6 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver") > Signed-off-by: Jonathan Marek > --- > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > index 369ee20a7ea95..2f19ab4db7208 100644 > --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > @@ -392,7 +392,7 @@ static int lpi_config_set(struct pinctrl_dev *pctldev, unsigned int group, > unsigned long *configs, unsigned int nconfs) > { > struct lpi_pinctrl *pctrl = dev_get_drvdata(pctldev->dev); > - unsigned int param, arg, pullup, strength; > + unsigned int param, arg, pullup = LPI_GPIO_BIAS_DISABLE, strength = 2; > bool value, output_enabled = false; > const struct lpi_pingroup *g; > unsigned long sval; > -- > 2.26.1 >