From: Sean Christopherson <seanjc@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Xu, Like" <like.xu@intel.com>,
Dmitry Vyukov <dvyukov@google.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, Like Xu <like.xu@linux.intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Jim Mattson <jmattson@google.com>,
kvm@vger.kernel.org,
"Thomas Gleixner
(x86/pti/timer/core/smp/irq/perf/efi/locking/ras/objtool)
(x86@kernel.org)" <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] x86/perf: Fix guest_get_msrs static call if there is no PMU
Date: Tue, 9 Mar 2021 09:05:00 -0800 [thread overview]
Message-ID: <YEeqvC4QmJcj+pkC@google.com> (raw)
In-Reply-To: <YEc1mFkaILfF37At@hirez.programming.kicks-ass.net>
On Tue, Mar 09, 2021, Peter Zijlstra wrote:
> On Tue, Mar 09, 2021 at 08:46:49AM +0100, Peter Zijlstra wrote:
> > On Mon, Mar 08, 2021 at 12:40:44PM -0800, Sean Christopherson wrote:
> > > On Mon, Mar 08, 2021, Peter Zijlstra wrote:
> >
> > > > Given the one user in atomic_switch_perf_msrs() that should work because
> > > > it doesn't seem to care about nr_msrs when !msrs.
> > >
> > > Uh, that commit quite cleary says:
> >
> > D0h! I got static_call_cond() and __static_call_return0 mixed up.
> > Anyway, let me see if I can make something work here.
>
> Does this work? I can never seem to start a VM, and if I do accidentally
> manage, then it never contains the things I need :/
Yep, once I found the dependencies in tip/sched/core (thank tip-bot!). I'll
send v2 your way.
next prev parent reply other threads:[~2021-03-09 17:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 22:33 [PATCH] x86/perf: Fix guest_get_msrs static call if there is no PMU Sean Christopherson
2021-03-08 2:25 ` Xu, Like
2021-03-08 7:12 ` Dmitry Vyukov
2021-03-08 8:35 ` Like Xu
2021-03-08 8:51 ` Dmitry Vyukov
2021-03-08 8:53 ` Peter Zijlstra
2021-03-08 12:01 ` Xu, Like
2021-03-08 20:40 ` Sean Christopherson
2021-03-09 7:46 ` Peter Zijlstra
2021-03-09 8:45 ` Peter Zijlstra
2021-03-09 17:05 ` Sean Christopherson [this message]
2021-03-09 17:07 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEeqvC4QmJcj+pkC@google.com \
--to=seanjc@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=dvyukov@google.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=jolsa@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu@intel.com \
--cc=like.xu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).