From: Minchan Kim <minchan@kernel.org>
To: David Hildenbrand <david@redhat.com>
Cc: Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
joaodias@google.com, surenb@google.com, cgoldswo@codeaurora.org,
willy@infradead.org, vbabka@suse.cz,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mm: disable LRU pagevec during the migration temporarily
Date: Tue, 9 Mar 2021 09:15:11 -0800 [thread overview]
Message-ID: <YEetHx49DPVlC0Ap@google.com> (raw)
In-Reply-To: <0ae7c7de-f274-c2ec-1b3a-a006ea280f98@redhat.com>
On Tue, Mar 09, 2021 at 05:31:09PM +0100, David Hildenbrand wrote:
>
> > > > Signed-off-by: Minchan Kim <minchan@kernel.org>
> > > > ---
> > > > * from v1 - https://lore.kernel.org/lkml/20210302210949.2440120-1-minchan@kernel.org/
> > > > * introduce __lru_add_drain_all to minimize changes - mhocko
> > > > * use lru_cache_disable for memory-hotplug
> > > > * schedule for every cpu at force_all_cpus
> > > >
> > > > * from RFC - http://lore.kernel.org/linux-mm/20210216170348.1513483-1-minchan@kernel.org
> > > > * use atomic and lru_add_drain_all for strict ordering - mhocko
> > > > * lru_cache_disable/enable - mhocko
> > > >
> > > > include/linux/migrate.h | 6 ++-
> > > > include/linux/swap.h | 2 +
> > > > mm/memory_hotplug.c | 3 +-
> > > > mm/mempolicy.c | 6 +++
> > > > mm/migrate.c | 13 ++++---
> > > > mm/page_alloc.c | 3 ++
> > > > mm/swap.c | 82 +++++++++++++++++++++++++++++++++--------
> > > > 7 files changed, 91 insertions(+), 24 deletions(-)
> > >
> > > Sorry for nit picking but I think the additional abstraction for
> > > migrate_prep is not really needed and we can remove some more code.
> > > Maybe we should even get rid of migrate_prep_local which only has a
> > > single caller and open coding lru draining with a comment would be
> > > better from code reading POV IMO.
> >
> > Thanks for the code. I agree with you.
> > However, in this moment, let's go with this one until we conclude.
> > The removal of migrate_prep could be easily done after that.
> > I am happy to work on it.
>
> Can you prepare + send along these cleanups so we can have a look at the end
> result?
>
> (either cleanups before or after your changes - doing cleanups before might
> be cleaner as we are not dealing with a fix here that we want to backport)
Okay, let me try one more time.
next prev parent reply other threads:[~2021-03-09 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 5:16 [PATCH v2 1/2] mm: disable LRU pagevec during the migration temporarily Minchan Kim
2021-03-09 5:16 ` [PATCH v2 2/2] mm: fs: Invalidate BH LRU during page migration Minchan Kim
2021-03-09 11:11 ` kernel test robot
2021-03-09 7:56 ` [PATCH v2 1/2] mm: disable LRU pagevec during the migration temporarily kernel test robot
2021-03-09 9:43 ` kernel test robot
2021-03-09 10:07 ` kernel test robot
2021-03-09 11:03 ` Michal Hocko
2021-03-09 16:29 ` Minchan Kim
2021-03-09 16:31 ` David Hildenbrand
2021-03-09 17:15 ` Minchan Kim [this message]
2021-03-09 17:54 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEetHx49DPVlC0Ap@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgoldswo@codeaurora.org \
--cc=david@redhat.com \
--cc=joaodias@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).