From: Minchan Kim <minchan@kernel.org>
To: Michal Hocko <mhocko@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
John Dias <joaodias@google.com>,
David Hildenbrand <david@redhat.com>,
Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH v2] mm: page_alloc: dump migrate-failed pages
Date: Tue, 9 Mar 2021 09:27:51 -0800 [thread overview]
Message-ID: <YEewF8c1ydu2pU0A@google.com> (raw)
In-Reply-To: <YEejCP5tzUtrAjcw@dhcp22.suse.cz>
On Tue, Mar 09, 2021 at 05:32:08PM +0100, Michal Hocko wrote:
> On Tue 09-03-21 08:15:41, Minchan Kim wrote:
> > On Tue, Mar 09, 2021 at 10:32:51AM +0100, Michal Hocko wrote:
> > > On Mon 08-03-21 12:20:47, Minchan Kim wrote:
> > > > alloc_contig_range is usually used on cma area or movable zone.
> > > > It's critical if the page migration fails on those areas so
> > > > dump more debugging message.
> > >
> > > I disagree with this statement. alloc_contig_range is not a reliable
> > > allocator. Any user, be it CMA or direct users of alloc_contig_range
> > > have to deal with allocation failures. Debugging information can be
> > > still useful but considering migration failures critical is
> > > overstatement to say the least.
> >
> > Fair enough. Let's change it.
> >
> > "Currently, debugging CMA allocation failure is too hard
> > due to lacking of page information. alloc_contig_range is
> > proper place to dump them since it has migrate-failed page
> > list."
>
> "Currently, debugging CMA allocation failures is quite limited. The most
> commong source of these failures seems to be page migration which
> doesn't provide any useful information on the reason of the failure by
> itself. alloc_contig_range can report those failures as it holds a list
> of migrate-failed pages."
Will take it. Thanks.
< snip >
> > > Somebody more familiar with the dynamic debugging infrastructure needs
> > > to have a look but from from a quick look it seems ok.
> > >
> > > Do we really need all the ugly ifdefery, though? Don't we want to have
> > > this compiled in all the time and just rely on the static branch managed
> > > by the dynamic debugging framework?
> >
> > I have no further idea to make it simple while we keep the flexibility
> > for arguments and print format.
> >
> > #if defined(CONFIG_DYNAMIC_DEBUG) || \
> > (defined(CONFIG_DYNAMIC_DEBUG_CORE) && defined(DYNAMIC_DEBUG_MODULE))
> > static void alloc_contig_dump_pages(struct list_head *page_list)
> > {
> > static DEFINE_RATELIMIT_STATE(_rs,
> > DEFAULT_RATELIMIT_INTERVAL,
> > DEFAULT_RATELIMIT_BURST);
> >
> > DEFINE_DYNAMIC_DEBUG_METADATA(descriptor,
> > "migrate failure");
> > if (DYNAMIC_DEBUG_BRANCH(descriptor) && __ratelimit(&_rs)) {
> > struct page *page;
> >
> > WARN(1, "failed callstack");
> > list_for_each_entry(page, page_list, lru)
> > dump_page(page, "migration failure");
> > }
> > }
> > #else
> > static inline void alloc_contig_dump_pages(struct list_head *page_list)
> > {
> > }
> > #endif
>
> First, you would be much better off by droping the rate limitting. I am
> nt really convinced this is really necessary as this is a debugging aid
> enabled on request. A single list can be large enough to swamp logs so
> why bother?
No problem. Just added since David mentioned hugetlb pages are easily
fail to mgirate at this moment.
Yes, We could add the ratelimit if we get complain.
>
> Also are all those CONFIG_DYNAMIC_DEBUG* ifdefs necessary? Can we
> simply enable DYNAMIC_DEBUG for page_alloc as I've suggested above?
They are different usecases.
With DYNAMIC_DEBUG_MODULE with CONFIG_DYNAMIC_DEBUG_CORE,
it works for only specific compile flags as you suggested.
(CONFIG_DYNAMIC_DEBUG_CORE is requirement to work DYNAMIC_DEBUG_MODULE.
With CONFIG_DYNAMIC_DEBUG, user could enable/disable every dynamic
debug places without needing DYNAMIC_DEBUG_MODULE flags for source
files.
Both usecase makes sense to me.
next prev parent reply other threads:[~2021-03-09 17:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 20:20 [PATCH v2] mm: page_alloc: dump migrate-failed pages Minchan Kim
2021-03-08 21:29 ` kernel test robot
2021-03-08 22:29 ` Minchan Kim
2021-03-09 0:41 ` [kbuild-all] " Rong Chen
2021-03-09 2:23 ` Minchan Kim
2021-03-09 0:21 ` Andrew Morton
2021-03-09 2:21 ` Minchan Kim
2021-03-09 0:30 ` kernel test robot
2021-03-09 0:30 ` [RFC PATCH] mm: page_alloc: alloc_contig_ratelimit() can be static kernel test robot
2021-03-09 9:32 ` [PATCH v2] mm: page_alloc: dump migrate-failed pages Michal Hocko
2021-03-09 16:15 ` Minchan Kim
2021-03-09 16:32 ` Michal Hocko
2021-03-09 17:27 ` Minchan Kim [this message]
2021-03-10 13:04 ` Michal Hocko
2021-03-10 15:59 ` Minchan Kim
2021-03-10 7:42 ` Minchan Kim
2021-03-10 8:20 ` David Hildenbrand
2021-03-10 15:45 ` Minchan Kim
2021-03-10 13:07 ` Michal Hocko
2021-03-10 16:05 ` Minchan Kim
2021-03-10 16:46 ` Michal Hocko
2021-03-10 17:06 ` Minchan Kim
2021-03-10 18:07 ` Minchan Kim
2021-03-10 13:26 ` Matthew Wilcox
2021-03-10 13:54 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEewF8c1ydu2pU0A@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jbaron@akamai.com \
--cc=joaodias@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).