* [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets
@ 2021-03-02 5:21 Rajendra Nayak
2021-03-02 5:21 ` [PATCH 2/2] pinctrl: qcom: sc7280: Fix SDC1_RCLK configurations Rajendra Nayak
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Rajendra Nayak @ 2021-03-02 5:21 UTC (permalink / raw)
To: agross, bjorn.andersson, linus.walleij
Cc: linux-arm-msm, linux-gpio, linux-kernel, Rajendra Nayak
The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000
due to an issue in the scripts generating the data.
Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")
Reported-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
drivers/pinctrl/qcom/pinctrl-sc7280.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c
index 8daccd5..49c4347 100644
--- a/drivers/pinctrl/qcom/pinctrl-sc7280.c
+++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c
@@ -1439,14 +1439,14 @@ static const struct msm_pingroup sc7280_groups[] = {
[172] = PINGROUP(172, qdss, _, _, _, _, _, _, _, _),
[173] = PINGROUP(173, qdss, _, _, _, _, _, _, _, _),
[174] = PINGROUP(174, qdss, _, _, _, _, _, _, _, _),
- [175] = UFS_RESET(ufs_reset, 0x1be000),
- [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x1b3000, 15, 0),
- [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0x1b3000, 13, 6),
- [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x1b3000, 11, 3),
- [179] = SDC_QDSD_PINGROUP(sdc1_data, 0x1b3000, 9, 0),
- [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0x1b4000, 14, 6),
- [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x1b4000, 11, 3),
- [182] = SDC_QDSD_PINGROUP(sdc2_data, 0x1b4000, 9, 0),
+ [175] = UFS_RESET(ufs_reset, 0xbe000),
+ [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3000, 15, 0),
+ [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0xb3000, 13, 6),
+ [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0xb3000, 11, 3),
+ [179] = SDC_QDSD_PINGROUP(sdc1_data, 0xb3000, 9, 0),
+ [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0xb4000, 14, 6),
+ [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xb4000, 11, 3),
+ [182] = SDC_QDSD_PINGROUP(sdc2_data, 0xb4000, 9, 0),
};
static const struct msm_pinctrl_soc_data sc7280_pinctrl = {
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] pinctrl: qcom: sc7280: Fix SDC1_RCLK configurations
2021-03-02 5:21 [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets Rajendra Nayak
@ 2021-03-02 5:21 ` Rajendra Nayak
2021-03-09 20:11 ` Bjorn Andersson
2021-03-09 20:05 ` [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets Bjorn Andersson
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Rajendra Nayak @ 2021-03-02 5:21 UTC (permalink / raw)
To: agross, bjorn.andersson, linus.walleij
Cc: linux-arm-msm, linux-gpio, linux-kernel, Rajendra Nayak
Fix SDC1_RCLK configurations which are in a different register so fix the
offset from 0xb3000 to 0xb3004.
Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")
Reported-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
drivers/pinctrl/qcom/pinctrl-sc7280.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c
index 49c4347..9d41abf 100644
--- a/drivers/pinctrl/qcom/pinctrl-sc7280.c
+++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c
@@ -1440,7 +1440,7 @@ static const struct msm_pingroup sc7280_groups[] = {
[173] = PINGROUP(173, qdss, _, _, _, _, _, _, _, _),
[174] = PINGROUP(174, qdss, _, _, _, _, _, _, _, _),
[175] = UFS_RESET(ufs_reset, 0xbe000),
- [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3000, 15, 0),
+ [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3004, 0, 6),
[177] = SDC_QDSD_PINGROUP(sdc1_clk, 0xb3000, 13, 6),
[178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0xb3000, 11, 3),
[179] = SDC_QDSD_PINGROUP(sdc1_data, 0xb3000, 9, 0),
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets
2021-03-02 5:21 [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets Rajendra Nayak
2021-03-02 5:21 ` [PATCH 2/2] pinctrl: qcom: sc7280: Fix SDC1_RCLK configurations Rajendra Nayak
@ 2021-03-09 20:05 ` Bjorn Andersson
2021-03-10 23:52 ` Linus Walleij
2021-03-11 10:40 ` Andy Shevchenko
3 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2021-03-09 20:05 UTC (permalink / raw)
To: Rajendra Nayak
Cc: agross, linus.walleij, linux-arm-msm, linux-gpio, linux-kernel
On Mon 01 Mar 23:21 CST 2021, Rajendra Nayak wrote:
> The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000
> due to an issue in the scripts generating the data.
>
> Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")
>
> Reported-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-sc7280.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> index 8daccd5..49c4347 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc7280.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> @@ -1439,14 +1439,14 @@ static const struct msm_pingroup sc7280_groups[] = {
> [172] = PINGROUP(172, qdss, _, _, _, _, _, _, _, _),
> [173] = PINGROUP(173, qdss, _, _, _, _, _, _, _, _),
> [174] = PINGROUP(174, qdss, _, _, _, _, _, _, _, _),
> - [175] = UFS_RESET(ufs_reset, 0x1be000),
> - [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x1b3000, 15, 0),
> - [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0x1b3000, 13, 6),
> - [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x1b3000, 11, 3),
> - [179] = SDC_QDSD_PINGROUP(sdc1_data, 0x1b3000, 9, 0),
> - [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0x1b4000, 14, 6),
> - [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x1b4000, 11, 3),
> - [182] = SDC_QDSD_PINGROUP(sdc2_data, 0x1b4000, 9, 0),
> + [175] = UFS_RESET(ufs_reset, 0xbe000),
> + [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3000, 15, 0),
> + [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0xb3000, 13, 6),
> + [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0xb3000, 11, 3),
> + [179] = SDC_QDSD_PINGROUP(sdc1_data, 0xb3000, 9, 0),
> + [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0xb4000, 14, 6),
> + [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xb4000, 11, 3),
> + [182] = SDC_QDSD_PINGROUP(sdc2_data, 0xb4000, 9, 0),
> };
>
> static const struct msm_pinctrl_soc_data sc7280_pinctrl = {
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] pinctrl: qcom: sc7280: Fix SDC1_RCLK configurations
2021-03-02 5:21 ` [PATCH 2/2] pinctrl: qcom: sc7280: Fix SDC1_RCLK configurations Rajendra Nayak
@ 2021-03-09 20:11 ` Bjorn Andersson
0 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2021-03-09 20:11 UTC (permalink / raw)
To: Rajendra Nayak
Cc: agross, linus.walleij, linux-arm-msm, linux-gpio, linux-kernel
On Mon 01 Mar 23:21 CST 2021, Rajendra Nayak wrote:
> Fix SDC1_RCLK configurations which are in a different register so fix the
> offset from 0xb3000 to 0xb3004.
>
> Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")
>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Reported-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---
> drivers/pinctrl/qcom/pinctrl-sc7280.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> index 49c4347..9d41abf 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc7280.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> @@ -1440,7 +1440,7 @@ static const struct msm_pingroup sc7280_groups[] = {
> [173] = PINGROUP(173, qdss, _, _, _, _, _, _, _, _),
> [174] = PINGROUP(174, qdss, _, _, _, _, _, _, _, _),
> [175] = UFS_RESET(ufs_reset, 0xbe000),
> - [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3000, 15, 0),
> + [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3004, 0, 6),
> [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0xb3000, 13, 6),
> [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0xb3000, 11, 3),
> [179] = SDC_QDSD_PINGROUP(sdc1_data, 0xb3000, 9, 0),
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets
2021-03-02 5:21 [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets Rajendra Nayak
2021-03-02 5:21 ` [PATCH 2/2] pinctrl: qcom: sc7280: Fix SDC1_RCLK configurations Rajendra Nayak
2021-03-09 20:05 ` [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets Bjorn Andersson
@ 2021-03-10 23:52 ` Linus Walleij
2021-03-11 10:40 ` Andy Shevchenko
3 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2021-03-10 23:52 UTC (permalink / raw)
To: Rajendra Nayak
Cc: Andy Gross, Bjorn Andersson, MSM, open list:GPIO SUBSYSTEM, linux-kernel
On Tue, Mar 2, 2021 at 6:22 AM Rajendra Nayak <rnayak@codeaurora.org> wrote:
> The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000
> due to an issue in the scripts generating the data.
>
> Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")
>
> Reported-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
Both patches applied for fixes!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets
2021-03-02 5:21 [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets Rajendra Nayak
` (2 preceding siblings ...)
2021-03-10 23:52 ` Linus Walleij
@ 2021-03-11 10:40 ` Andy Shevchenko
2021-03-11 14:40 ` Linus Walleij
3 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2021-03-11 10:40 UTC (permalink / raw)
To: Rajendra Nayak
Cc: Andy Gross, Bjorn Andersson, Linus Walleij, linux-arm-msm,
open list:GPIO SUBSYSTEM, Linux Kernel Mailing List
On Tue, Mar 2, 2021 at 9:32 PM Rajendra Nayak <rnayak@codeaurora.org> wrote:
>
> The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000
> due to an issue in the scripts generating the data.
> Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")
>
> Reported-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
Should be no blank lines in the tag block.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets
2021-03-11 10:40 ` Andy Shevchenko
@ 2021-03-11 14:40 ` Linus Walleij
0 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2021-03-11 14:40 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Rajendra Nayak, Andy Gross, Bjorn Andersson, MSM,
open list:GPIO SUBSYSTEM, Linux Kernel Mailing List
On Thu, Mar 11, 2021 at 11:41 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Tue, Mar 2, 2021 at 9:32 PM Rajendra Nayak <rnayak@codeaurora.org> wrote:
> >
> > The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000
> > due to an issue in the scripts generating the data.
>
> > Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")
> >
> > Reported-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>
> Should be no blank lines in the tag block.
Yeah I fixed it up when applying.
Just one of these maintainer perks I offer free of charge ;)
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-11 14:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-02 5:21 [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets Rajendra Nayak
2021-03-02 5:21 ` [PATCH 2/2] pinctrl: qcom: sc7280: Fix SDC1_RCLK configurations Rajendra Nayak
2021-03-09 20:11 ` Bjorn Andersson
2021-03-09 20:05 ` [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets Bjorn Andersson
2021-03-10 23:52 ` Linus Walleij
2021-03-11 10:40 ` Andy Shevchenko
2021-03-11 14:40 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).