From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chris Down <chris@chrisdown.name>
Cc: linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
John Ogness <john.ogness@linutronix.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Kees Cook <keescook@chromium.org>,
kernel-team@fb.com
Subject: Re: [PATCH v5] printk: Userspace format enumeration support
Date: Wed, 10 Mar 2021 13:16:43 +0100 [thread overview]
Message-ID: <YEi4qwBAd/O+sXyq@kroah.com> (raw)
In-Reply-To: <YEi3ySLkw3hZinnS@chrisdown.name>
On Wed, Mar 10, 2021 at 12:12:57PM +0000, Chris Down wrote:
> Greg Kroah-Hartman writes:
> > On Wed, Mar 10, 2021 at 02:30:31AM +0000, Chris Down wrote:
> > > + ps->file = debugfs_create_file(pi_get_module_name(mod), 0444, dfs_index,
> > > + ps, &dfs_index_fops);
> > > +
> > > + if (IS_ERR(ps->file)) {
> > > + pi_sec_remove(mod);
> > > + return;
> > > + }
> >
> > No need to check this and try to clean up if there is a problem, just
> > save the pointer off and call debugfs_remove() when you want to clean
> > up.
>
> Petr, what are your thoughts on this, since you requested the cleanup on
> debugfs failure? :-)
There is nothing to "clean up" if there is a debugfs failure here so I
don't see the need.
> > Or better yet, no need to save anything, you can always look it up when
> > you want to remove it, that will save you one pointer per module.
>
> That's a good point, and with that maybe we can even do away with the pi_sec
> entirely then since that only leaves start/end pointers which we can
> calculate on demand from existing data.
Please do, that makes the code simpler overall.
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-10 12:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 2:30 [PATCH v5] printk: Userspace format enumeration support Chris Down
2021-03-10 6:20 ` kernel test robot
2021-03-10 6:50 ` Greg Kroah-Hartman
2021-03-10 12:12 ` Chris Down
2021-03-10 12:16 ` Greg Kroah-Hartman [this message]
2021-03-11 9:34 ` Petr Mladek
2021-03-11 9:43 ` Greg Kroah-Hartman
2021-03-10 12:17 ` Chris Down
2021-03-11 9:20 ` Petr Mladek
2021-03-10 12:31 ` kernel test robot
2021-03-12 11:14 ` Petr Mladek
2021-03-12 13:53 ` Chris Down
2021-03-15 10:02 ` Petr Mladek
2021-03-15 12:20 ` Chris Down
2021-03-16 11:39 ` Petr Mladek
2021-03-16 13:27 ` Chris Down
2021-03-16 14:12 ` Rasmus Villemoes
2021-03-16 14:28 ` Chris Down
2021-03-17 8:40 ` Petr Mladek
2021-03-17 10:03 ` Rasmus Villemoes
2021-03-18 10:46 ` Petr Mladek
2021-03-18 11:31 ` Rasmus Villemoes
2021-03-19 11:43 ` Petr Mladek
2021-04-16 13:56 ` Chris Down
2021-04-16 14:09 ` Joe Perches
2021-04-16 14:29 ` Chris Down
2021-04-19 7:27 ` Rasmus Villemoes
2021-04-19 9:16 ` Petr Mladek
2021-04-19 9:53 ` Greg Kroah-Hartman
2021-04-19 11:02 ` Joe Perches
2021-04-21 13:14 ` Chris Down
2021-04-22 12:36 ` Joe Perches
2021-04-22 14:59 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEi4qwBAd/O+sXyq@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=chris@chrisdown.name \
--cc=hannes@cmpxchg.org \
--cc=john.ogness@linutronix.de \
--cc=keescook@chromium.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).