From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22D29C433E6 for ; Fri, 12 Mar 2021 14:06:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6DBA65004 for ; Fri, 12 Mar 2021 14:06:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231216AbhCLOF2 (ORCPT ); Fri, 12 Mar 2021 09:05:28 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:53880 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229909AbhCLOFV (ORCPT ); Fri, 12 Mar 2021 09:05:21 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lKiPi-00AXAn-MH; Fri, 12 Mar 2021 15:05:14 +0100 Date: Fri, 12 Mar 2021 15:05:14 +0100 From: Andrew Lunn To: Lee Jones Cc: linux-kernel@vger.kernel.org, Heiner Kallweit , Russell King , Rob Herring , Frank Rowand , netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 08/10] of: of_net: Demote non-conforming kernel-doc header Message-ID: References: <20210312110758.2220959-1-lee.jones@linaro.org> <20210312110758.2220959-9-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210312110758.2220959-9-lee.jones@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 12, 2021 at 11:07:56AM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/of/of_net.c:104: warning: Function parameter or member 'np' not described in 'of_get_mac_address' > drivers/of/of_net.c:104: warning: expecting prototype for mac(). Prototype was for of_get_mac_address() instead > > Cc: Andrew Lunn > Cc: Heiner Kallweit > Cc: Russell King > Cc: Rob Herring > Cc: Frank Rowand > Cc: netdev@vger.kernel.org > Cc: devicetree@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/of/of_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/of_net.c b/drivers/of/of_net.c > index 6e411821583e4..9b41a343e88ab 100644 > --- a/drivers/of/of_net.c > +++ b/drivers/of/of_net.c > @@ -78,7 +78,7 @@ static const void *of_get_mac_addr_nvmem(struct device_node *np) > return mac; > } > > -/** > +/* > * Search the device tree for the best MAC address to use. 'mac-address' is > * checked first, because that is supposed to contain to "most recent" MAC > * address. If that isn't set, then 'local-mac-address' is checked next, Hi Lee of_get_mac_address() is a pretty important API function. So it would be better to add the missing header to make this valid kdoc. /** * of_get_mac_address - Get MAC address from device tree * @np: Pointer to the device_node of the interface * Andrew