From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CD78C433E6 for ; Fri, 12 Mar 2021 17:14:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E93F26501D for ; Fri, 12 Mar 2021 17:14:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232804AbhCLROZ (ORCPT ); Fri, 12 Mar 2021 12:14:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232984AbhCLROM (ORCPT ); Fri, 12 Mar 2021 12:14:12 -0500 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBBA9C061574 for ; Fri, 12 Mar 2021 09:14:11 -0800 (PST) Received: by mail-oi1-x230.google.com with SMTP id d16so18252213oic.0 for ; Fri, 12 Mar 2021 09:14:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lfE3Tva2EoQ6qXyouptwS/JNUmC9k+8pBSYHmEHX/4E=; b=SPbSVI8otiDLbohvEOc1Iwd7Z9bWZ5EfV8yNdqeLw2Ko9dc68L0O7/XOy+ZQGjcrgm KeZr8V/zRo5/PaBF1w3DLqLBF6Khj0OZjGMRkL3LjKCkZDsgfoYtEIrRSQie8rce2b1S /ewv7h6qUod6oaWEyw84bmpZoqglt5VWdUeCOVskk23CQm60h8g14coAtTZlaBQ0uIIH kWxfACfdVnOg9XaBu4DT7RYLLTaEYPGvTH84Fn67phe8gwbOqNcXTdyUGX5JUpIy0iqZ Cn2bqLK4gr4V0ZL42Qf7Sk1UxhnYhePNb5Q+kF1uTumsVzdOW4p680xz6A4afiHY9lZt 3tQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lfE3Tva2EoQ6qXyouptwS/JNUmC9k+8pBSYHmEHX/4E=; b=M0MXkQqpwGggH0/2o1fEYvAuxU+Q2dzbeAJiRhFQOerFn0dm8HMk+RH3VNOC6x45CW LKODc20f3KvIWANmi9TBZr4AmdyY+1DTI7WGc7sQWtaMbhash/xTp4pnUGpO6Tw25EyC Aeqp0t/CJsbG0+kzi2Ew4tb1dTf7wPeV9K5naHjBE/1hUBMVaxGTBVm91q1da1wrPavu E3/k0URBC0AKOrIHHVwTOE7uYgkCC0rR0uHHgYh0NwbDej+KNlVhbvvYcVsbBPoeKrwo dxesYOdh/c6rCELHST+yB/JvkH/FSik/I26M0KuQhkDFEZYwfkScNcumAXsgI+kQxMYb saQg== X-Gm-Message-State: AOAM530OkYq1NsSBq9Zf1nA/UX5XU7y1phzKky1+cdkqJqtvRIgyzCeZ Kl+/IEZQcgBILl8DNNHTmofw9g== X-Google-Smtp-Source: ABdhPJwFn76xWftUWS0EeIEao0boAwPNQUmViHSD4s5LTOSf9w1iWNRs/r2NycrT49OQh3Ep0ojsdg== X-Received: by 2002:aca:3307:: with SMTP id z7mr10154124oiz.34.1615569251272; Fri, 12 Mar 2021 09:14:11 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id n1sm1459174oig.47.2021.03.12.09.14.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 09:14:10 -0800 (PST) Date: Fri, 12 Mar 2021 11:14:09 -0600 From: Bjorn Andersson To: Stephen Boyd Cc: Maulik Shah , evgreen@chromium.org, mka@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, agross@kernel.org, dianders@chromium.org, linux@roeck-us.net, rnayak@codeaurora.org, ilina@codeaurora.org, lsrao@codeaurora.org, Mahesh Sivasubramanian , devicetree@vger.kernel.org Subject: Re: [PATCH v6 1/4] dt-bindings: Introduce SoC sleep stats bindings Message-ID: References: <1612448508-9179-1-git-send-email-mkshah@codeaurora.org> <1612448508-9179-2-git-send-email-mkshah@codeaurora.org> <161283021256.76967.600110253862291436@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <161283021256.76967.600110253862291436@swboyd.mtv.corp.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 08 Feb 18:23 CST 2021, Stephen Boyd wrote: > Quoting Maulik Shah (2021-02-04 06:21:45) > > + > > +description: > > + Always On Processor/Resource Power Manager maintains statistics of the SoC > > + sleep modes involving powering down of the rails and oscillator clock. > > + > > + Statistics includes SoC sleep mode type, number of times low power mode were > > + entered, time of last entry, time of last exit and accumulated sleep duration. > > + > > +properties: > > + compatible: > > + enum: > > + - qcom,rpmh-sleep-stats > > + - qcom,rpm-sleep-stats > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +examples: > > + # Example of rpmh sleep stats > > + - | > > + rpmh-sleep-stats@c3f0000 { > > + compatible = "qcom,rpmh-sleep-stats"; > > + reg = <0 0x0c3f0000 0 0x400>; > > + }; > > Maybe it should just be another reg property of the rpmh or rpm node? > Then the rpmh driver can create the stats "device" at driver probe time, > or just roll it into the same thing. It looks pretty weird to have a > device in DT for this given that it's not really hardware, more like a > place that the processor writes some stuff about what's going on in the > SoC related to power management. > Given that there is some hardware (although just a chunk of sram) and that the same driver is used for RPM, which we don't represent on the mmio bus I think the proposed design makes sense. Regards, Bjorn > > + # Example of rpm sleep stats > > + - | > > + rpm-sleep-stats@4690000 { > > + compatible = "qcom,rpm-sleep-stats"; > > + reg = <0 0x04690000 0 0x400>; > > + }; > > +...