From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 115BCC433E6 for ; Fri, 12 Mar 2021 21:45:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E180864F89 for ; Fri, 12 Mar 2021 21:45:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235341AbhCLVpO (ORCPT ); Fri, 12 Mar 2021 16:45:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235296AbhCLVpH (ORCPT ); Fri, 12 Mar 2021 16:45:07 -0500 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD65BC061574 for ; Fri, 12 Mar 2021 13:45:06 -0800 (PST) Received: by mail-pf1-x42e.google.com with SMTP id 18so2761574pfo.6 for ; Fri, 12 Mar 2021 13:45:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=x7D4wx4txlNBgp7gkpJLfngOVwKdjZaDmVpicz7DAY4=; b=pTf4mbw4jbXZjOuoMn+tuTw2O1Xj6MyUg3SqxwF+JQIgEmgVKFNOCGgWa1Dd4VCcb8 6BMMguTPhhRaFTFymZJX0yquozaGXf1z1uJYCse9BWNAanT+JBAxgK5n5wZS6Nua0woM ylv9h5+iTKYi7PKfmQ6An+a7xYiI4XRFPACp5H5QQpFdLlbBuGbH6+ZFmc9ZNXRvabxj XryOlDtxv0bQGACGkWfy33nZlkRY5zWpUEbjzDBP6/CrpuDlAC1kuNd+fh1GErieAZGm mFZgG5FqNSLpqK9p5GgpSTiaTXYflbwB8YDPVYaClUXFs9tMHrGZ7AlKNb8EBei85cSx 5uow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=x7D4wx4txlNBgp7gkpJLfngOVwKdjZaDmVpicz7DAY4=; b=CxknN+yObjcDoBDw74xxk++d4SAgAM0TPs7KSBgvLBYjsrWckSkYPz2XyZ7+ZPkWT0 6y1EdXG+MyCq7wqEgnv38xGYU0LD9993IU7hnJOM3pWaEREY1trWRz5smNTkJ+b25owT AjML0p7JSruHboLyTDcDUJGCAl/dn3wHq8ohSAxTnrZwwXj5CWm+761pmi55grlYNDA2 rcRDTkSF5JSHaqdNLbKwX7CJY9xBzH9bj9bXv11oZis4+tZhjdgNJs47gqBhHvcbq5j5 JcoigyOI1SyYuJkcBfOXR/zabBe2X3VTSvG3WqCTeGiGLYwK0jGbwHWW0iwknPhdi7qs zjZA== X-Gm-Message-State: AOAM531UtPKfJ5XFcHkkYu44QB20HlskXH1xSeTXTUWlYz8FnODt8Ilu Fdt8VHRXfwsP5UH7gJs6juEWow== X-Google-Smtp-Source: ABdhPJxnN/QGTf+wnEPW4XpmbpqhI2bE/23csUm9gWJ18Ute1hlfIiSxwTfb/12TMRKVrMDgCRq0cg== X-Received: by 2002:aa7:92d9:0:b029:1bb:b6de:c872 with SMTP id k25-20020aa792d90000b02901bbb6dec872mr177679pfa.68.1615585506293; Fri, 12 Mar 2021 13:45:06 -0800 (PST) Received: from google.com ([2620:15c:f:10:e1a6:2eeb:4e45:756]) by smtp.gmail.com with ESMTPSA id x7sm3003749pjr.7.2021.03.12.13.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 13:45:05 -0800 (PST) Date: Fri, 12 Mar 2021 13:44:58 -0800 From: Sean Christopherson To: Kai Huang Cc: kvm@vger.kernel.org, linux-sgx@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, jarkko@kernel.org, luto@kernel.org, dave.hansen@intel.com, rick.p.edgecombe@intel.com, haitao.huang@intel.com, pbonzini@redhat.com, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com Subject: Re: [PATCH v2 07/25] x86/sgx: Initialize virtual EPC driver even when SGX driver is disabled Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 09, 2021, Kai Huang wrote: > Modify sgx_init() to always try to initialize the virtual EPC driver, > even if the SGX driver is disabled. The SGX driver might be disabled > if SGX Launch Control is in locked mode, or not supported in the > hardware at all. This allows (non-Linux) guests that support non-LC > configurations to use SGX. > > Acked-by: Dave Hansen > Signed-off-by: Kai Huang > --- > arch/x86/kernel/cpu/sgx/main.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/sgx/main.c b/arch/x86/kernel/cpu/sgx/main.c > index 44fe91a5bfb3..8c922e68274d 100644 > --- a/arch/x86/kernel/cpu/sgx/main.c > +++ b/arch/x86/kernel/cpu/sgx/main.c > @@ -712,7 +712,15 @@ static int __init sgx_init(void) > goto err_page_cache; > } > > - ret = sgx_drv_init(); > + /* > + * Always try to initialize the native *and* KVM drivers. > + * The KVM driver is less picky than the native one and > + * can function if the native one is not supported on the > + * current system or fails to initialize. > + * > + * Error out only if both fail to initialize. > + */ > + ret = !!sgx_drv_init() & !!sgx_vepc_init(); I love this code. Reviewed-by: Sean Christopherson > if (ret) > goto err_kthread; > > -- > 2.29.2 >