From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Barry Song <song.bao.hua@hisilicon.com>
Cc: tglx@linutronix.de, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, maz@kernel.org,
gregkh@linuxfoundation.org, linuxarm@openeuler.org,
jonathan.cameron@huawei.com
Subject: Re: [PATCH v5 2/2] Input: move to use request_irq by IRQF_NO_AUTOEN flag
Date: Thu, 25 Mar 2021 15:31:44 -0700 [thread overview]
Message-ID: <YF0PUMvvH996Xj3+@google.com> (raw)
In-Reply-To: <20210302224916.13980-3-song.bao.hua@hisilicon.com>
On Wed, Mar 03, 2021 at 11:49:16AM +1300, Barry Song wrote:
> disable_irq() after request_irq() still has a time gap in which
> interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> disable IRQ auto-enable because of requesting.
>
> On the other hand, request_irq() after setting IRQ_NOAUTOEN as
> below
> irq_set_status_flags(irq, IRQ_NOAUTOEN);
> request_irq(dev, irq...);
> can also be replaced by request_irq() with IRQF_NO_AUTOEN flag.
>
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2021-03-25 22:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 22:49 [PATCH v5 0/2] add IRQF_NO_AUTOEN for request_irq Barry Song
2021-03-02 22:49 ` [PATCH v5 1/2] genirq: " Barry Song
2021-03-04 10:53 ` [tip: irq/core] genirq: Add IRQF_NO_AUTOEN for request_irq/nmi() tip-bot2 for Barry Song
2021-03-04 10:57 ` Thomas Gleixner
2021-03-04 18:50 ` Thomas Gleixner
2021-03-23 22:44 ` Dmitry Torokhov
2021-03-25 6:59 ` Thomas Gleixner
2021-03-25 22:32 ` Dmitry Torokhov
2021-03-06 11:54 ` tip-bot2 for Barry Song
2021-03-02 22:49 ` [PATCH v5 2/2] Input: move to use request_irq by IRQF_NO_AUTOEN flag Barry Song
2021-03-25 22:31 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF0PUMvvH996Xj3+@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathan.cameron@huawei.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=maz@kernel.org \
--cc=song.bao.hua@hisilicon.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).