From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CDCCC433DB for ; Fri, 26 Mar 2021 14:09:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54047619B1 for ; Fri, 26 Mar 2021 14:09:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230080AbhCZOIY (ORCPT ); Fri, 26 Mar 2021 10:08:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:44240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229839AbhCZOIH (ORCPT ); Fri, 26 Mar 2021 10:08:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0D24861A24; Fri, 26 Mar 2021 14:08:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616767687; bh=sfKejFZdHc5ocWb1u29Ga9LhysZMd+NqlM93fFQXeLc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wN2ED4td46fy0E+xRVuWJcEoR+TURtgYYeFTQnmwfzznS/s96egLlT+pOxYTfz4yG NO2+OrzveTor9cJTr/O0m2UeQ4Z3LREi8JGMsnB3Uy5iLeXR/uFlQYn/7mhUPFHjoa 6dr27IR72nYvDggowmZslO8agE8NROpjOk4fD66c= Date: Fri, 26 Mar 2021 15:08:05 +0100 From: Greg KH To: Xu Jia Cc: ross.schm.dev@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, hulkcommits@huawei.com Subject: Re: [PATCH -next] staging: rtl8723bs: core: fix error return Message-ID: References: <20210325083041.1881347-1-xujia39@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210325083041.1881347-1-xujia39@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 25, 2021 at 04:30:41PM +0800, Xu Jia wrote: > Function rtw_init_bcmc_stainfo() is always return success. > Variable 'ret' set but not used. > > Reported-by: Hulk Robot > Signed-off-by: Xu Jia > --- > drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c > index f96dd0b40e04..7b578192adf5 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c > +++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c > @@ -551,7 +551,7 @@ u32 rtw_init_bcmc_stainfo(struct adapter *padapter) > psta->mac_id = 1; > > exit: > - return _SUCCESS; > + return res; > } You just changed the logic of this function, now it can return a failure. Is that ok? have you tested it when this fails? Given that I do not think anyone actually tests this value, should this function just return void instead? thanks, greg k-h