From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE0F1C433DB for ; Sat, 27 Mar 2021 15:27:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B50ED61969 for ; Sat, 27 Mar 2021 15:27:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230296AbhC0P0p (ORCPT ); Sat, 27 Mar 2021 11:26:45 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:51132 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230086AbhC0P0I (ORCPT ); Sat, 27 Mar 2021 11:26:08 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lQAp3-00DLWU-Jx; Sat, 27 Mar 2021 16:25:57 +0100 Date: Sat, 27 Mar 2021 16:25:57 +0100 From: Andrew Lunn To: Don Bollinger Cc: 'Jakub Kicinski' , arndb@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, brandon_chuang@edge-core.com, wally_wang@accton.com, aken_liu@edge-core.com, gulv@microsoft.com, jolevequ@microsoft.com, xinxliu@microsoft.com, 'netdev' , 'Moshe Shemesh' Subject: Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS Message-ID: References: <009601d72023$b73dbde0$25b939a0$@thebollingers.org> <011301d7226f$dc2426f0$946c74d0$@thebollingers.org> <011901d7227c$e00015b0$a0004110$@thebollingers.org> <011c01d72284$544c8f50$fce5adf0$@thebollingers.org> <012b01d7228f$a2547270$e6fd5750$@thebollingers.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <012b01d7228f$a2547270$e6fd5750$@thebollingers.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > What I have works. Your consumers get quirk handling, mine don't need it. > No compromise. Hi Don All this discussion is now a mute point. GregKH has spoken. But i'm sure there are some on the side lines, eating popcorn, maybe learning from the discussion. Would you think it is O.K. to add a KAPI which works for 3 1/2" SCSI disks, but not 2", because you only make machines with 3 1/2" bays? This is an extreme, absurd example, but hopefully you get the point. We don't design KAPIs with the intention to only work for a subset of devices. It needs to work with as many devices as possible, even if the first implementation below the KAPI is limited to just a subset. Anyway, i'm gratefull you have looked at the new ethtool netlink KAPI. It will be better for your contributions. And i hope you can make use of it in the future. But i think this discussion about optoe in mainline is over. Andrew