From: Greg KH <gregkh@linuxfoundation.org>
To: Mihai Carabas <mihai.carabas@oracle.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
bobo.shaobowang@huawei.com, rdunlap@infradead.org
Subject: Re: [PATCH v5 3/3] misc/pvpanic: add PCI driver
Date: Tue, 16 Mar 2021 18:29:09 +0100 [thread overview]
Message-ID: <YFDq5Wj4AQOm/Bm4@kroah.com> (raw)
In-Reply-To: <b3d33f82-21ab-2244-13b0-700fc54b2093@oracle.com>
On Tue, Mar 16, 2021 at 07:08:38PM +0200, Mihai Carabas wrote:
> ..snip..
> > > +};
> > > +static unsigned int capability = PVPANIC_PANICKED | PVPANIC_CRASH_LOADED;
> > > +static unsigned int events;
> > > +
> > > +static ssize_t capability_show(struct device *dev,
> > > + struct device_attribute *attr, char *buf)
> > > +{
> > > + return sysfs_emit(buf, "%x\n", capability);
> > A global capability for all devices? No, this needs to be a per-device
> > attttribute as you are showing it to userspace as such.
>
> We can only have a pvpanic-pci device. This is necessary in that case?
Why would it not be? Why constrain yourself to something that someone
will only have to fix sometime in the future?
> ...snip..
> > > +static struct attribute *pvpanic_pci_dev_attrs[] = {
> > > + &dev_attr_capability.attr,
> > > + &dev_attr_events.attr,
> > > + NULL
> > > +};
> > > +ATTRIBUTE_GROUPS(pvpanici_pci_dev);
> > You did not document these new sysfs files in Documentation/ABI/ so it's
> > hard to judge what they do. Please do so next version.
>
> This appeared after 5.12 rebase on pvpanic-mmio. I did this changes to
> pvpanic-pci to be on the same page as pvpanic-mmio which is described here:
> Documentation/ABI/testing/sysfs-bus-pci-devices-pvpanic.
Ah, missed that, my fault, sorry. But you also now do this for the
other device type right? So does the documentation need to reflect that
too?
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-16 17:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 12:20 [PATCH v5] add support for pci in the pvpanic driver Mihai Carabas
2021-03-16 12:20 ` [PATCH v5 1/3] misc/pvpanic: split-up generic and platform dependent code Mihai Carabas
2021-03-16 16:44 ` Greg KH
2021-03-16 12:20 ` [PATCH v5 2/3] misc/pvpanic: probe multiple instances Mihai Carabas
2021-03-16 16:46 ` Greg KH
2021-03-16 12:20 ` [PATCH v5 3/3] misc/pvpanic: add PCI driver Mihai Carabas
2021-03-16 16:48 ` Greg KH
2021-03-16 17:08 ` Mihai Carabas
2021-03-16 17:29 ` Greg KH [this message]
2021-03-16 18:02 ` Mihai Carabas
2021-03-16 18:16 ` Greg KH
2021-03-17 0:02 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFDq5Wj4AQOm/Bm4@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bobo.shaobowang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.carabas@oracle.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).