From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42122C433E0 for ; Wed, 17 Mar 2021 08:13:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1642E64FB2 for ; Wed, 17 Mar 2021 08:13:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229506AbhCQIMx (ORCPT ); Wed, 17 Mar 2021 04:12:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbhCQIMU (ORCPT ); Wed, 17 Mar 2021 04:12:20 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD710C06175F for ; Wed, 17 Mar 2021 01:12:19 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id j6so392626plx.6 for ; Wed, 17 Mar 2021 01:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zLY15HRdmjN+WzEM6Wb9ghJnMYS5GHNsHkgt7obEDCM=; b=c6ZgUWtqaq8Pu7xQlqPoKl8CX3atGgQHi577Sj+2KOyhTPAQQYvstQUKN397PFTwaN R7vZvQHgY9B8R3b2YC9EH5WCADvgr4+5uNFTG6+VzTZcFMFi6fdLxDbFUhtwpCoQ3FqD NOU+b161/ArEZtIWOvjgdosNKT3CIc7+n/fdE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zLY15HRdmjN+WzEM6Wb9ghJnMYS5GHNsHkgt7obEDCM=; b=ZmGvY2cxo/EHu5kmcda+LSU5qqTkneCt9+Ac/mRqUUARZOamnhnU7PeGg9wzfC/6ZA okEo1wK+xlwP3Z8T7n9RxMAOs1sx8DziHzZ1Ld89hJj7QeqPnI45sesUtAEjY+49X7nE 8j2YVXaj7dlZjgtGRhHPzWrJtxVIDQNGuWVdw8ZAXpCeCa/VzZZw2zk23VFVQZVmJxoW xexq8x3ZYcEcdFIEU8MfhLpMzvnnEIzpRliTNeOZroBg4WtxFOU9r2uGWvIl9CaoDjib mCW/i1MjBeBj5dbLA4aDZAiOxrPHIWCZDdUY6V05rJi84AvlMiASD1zlTcs4RbzdqmJ/ twew== X-Gm-Message-State: AOAM533uNeLMWp6Fwo2n0eUJz89ZoXsNAZxcnaVpTUTPxvjQHel0VDUd qFhz8/wZj5FYKTddCGB0AthY8A== X-Google-Smtp-Source: ABdhPJwnW6oAfoxq5uuWhck8IodvFib2eXowUm6fAuUHOK6MrqUJp3RkyoYyCTxx5YIXYOtnpc3hIw== X-Received: by 2002:a17:902:8c92:b029:e6:60ad:6924 with SMTP id t18-20020a1709028c92b02900e660ad6924mr3319720plo.16.1615968739531; Wed, 17 Mar 2021 01:12:19 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:b48f:f050:bdc5:eb89]) by smtp.gmail.com with ESMTPSA id 138sm18608063pfv.192.2021.03.17.01.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:12:19 -0700 (PDT) Date: Wed, 17 Mar 2021 17:12:14 +0900 From: Sergey Senozhatsky To: Ricardo Ribalda Delgado Cc: Sergey Senozhatsky , Sergey Senozhatsky , Laurent Pinchart , Tomasz Figa , Mauro Carvalho Chehab , linux-media , LKML , Sergey Senozhatsky , Ricardo Ribalda Subject: Re: [PATCHv2 2/3] media: uvcvideo: add ROI auto controls Message-ID: References: <20210208051749.1785246-1-sergey.senozhatsky@gmail.com> <20210208051749.1785246-3-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixed Tomasz's email On (21/03/17 09:08), Ricardo Ribalda Delgado wrote: [..] > > > > + .id = V4L2_CID_REGION_OF_INTEREST_AUTO, > > > > + .name = "Region of Interest (auto)", > > > > + .entity = UVC_GUID_UVC_CAMERA, > > > > + .selector = UVC_CT_REGION_OF_INTEREST_CONTROL, > > > > + .size = 16, > > > > + .offset = 64, > > > > + .v4l2_type = V4L2_CTRL_TYPE_BITMASK, > > > Are > > > > Are? > > Aye! > You are not a good kernel reviewer if you do not talk pirate :P. Arr, Matey! -ss