From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47551C4332B for ; Wed, 17 Mar 2021 10:07:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EB4764F96 for ; Wed, 17 Mar 2021 10:07:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230154AbhCQKGl (ORCPT ); Wed, 17 Mar 2021 06:06:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42330 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229939AbhCQKGg (ORCPT ); Wed, 17 Mar 2021 06:06:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615975596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MElDg3cG/3Dz6lM5WJjnup4TWCLl29WwGaKclvjIThc=; b=ii9UoEW6bnnup2HcokSZooVvkR1OWfgl2wMJIfVQPc+98gfFLiGuAd5/kvyZ7TOzGJlf4H o826eUa30Azruff1/VzRVT4jkVcycVBtjrGzRnn6cX272VYSvleJjip6xlYCWI9/SXWLTr TMO1wBW2xq6BLqXtkuBC1QgWYkxqNL4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-487-ceAsTIv0MO6sCRvLL6fdSw-1; Wed, 17 Mar 2021 06:06:32 -0400 X-MC-Unique: ceAsTIv0MO6sCRvLL6fdSw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8DB0A107ACCD; Wed, 17 Mar 2021 10:06:30 +0000 (UTC) Received: from krava (unknown [10.40.194.149]) by smtp.corp.redhat.com (Postfix) with SMTP id 302865C261; Wed, 17 Mar 2021 10:06:27 +0000 (UTC) Date: Wed, 17 Mar 2021 11:06:27 +0100 From: Jiri Olsa To: "Jin, Yao" Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v2 11/27] perf parse-events: Support hardware events inside PMU Message-ID: References: <20210311070742.9318-1-yao.jin@linux.intel.com> <20210311070742.9318-12-yao.jin@linux.intel.com> <65624432-2752-8381-d299-9b48ec508406@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65624432-2752-8381-d299-9b48ec508406@linux.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 17, 2021 at 10:12:03AM +0800, Jin, Yao wrote: > > > On 3/16/2021 10:04 PM, Jiri Olsa wrote: > > On Tue, Mar 16, 2021 at 09:49:42AM +0800, Jin, Yao wrote: > > > > SNIP > > > > > > > > Performance counter stats for 'system wide': > > > > > > 136,655,302 cpu_core/branch-instructions/ > > > > > > 1.003171561 seconds time elapsed > > > > > > So we need special rules for both cycles and branches. > > > > > > The worse thing is, we also need to process the hardware cache events. > > > > > > # ./perf stat -e cpu_core/LLC-loads/ > > > event syntax error: 'cpu_core/LLC-loads/' > > > \___ unknown term 'LLC-loads' for pmu 'cpu_core' > > > > > > valid terms: event,pc,edge,offcore_rsp,ldlat,inv,umask,frontend,cmask,config,config1,config2,name,period,percore > > > > > > Initial error: > > > event syntax error: 'cpu_core/LLC-loads/' > > > \___ unknown term 'LLC-loads' for pmu 'cpu_core' > > > > > > If we use special rules for establishing all event mapping, that looks too much. :( > > > > hmmm but wait, currently we do not support events like this: > > > > 'cpu/cycles/' > > 'cpu/branches/' > > > > the pmu style accepts only 'events' or 'format' terms within // > > > > we made hw events like 'cycles','instructions','branches' special > > to be used without the pmu > > > > so why do we need to support cpu_code/cycles/ ? > > > > jirka > > > > Actually we have to support pmu style event for hybrid platform. > > User may want to enable the events from specified pmus and also with flexible grouping. > > For example, > > perf stat -e '{cpu_core/cycles/,cpu_core/instructions/}' -e '{cpu_atom/cycles/,cpu_atom/instructions/}' > > This usage is common and reasonable. So I think we may need to support pmu style events. sure, but we don't support 'cpu/cycles/' but we support 'cpu/cpu-cycles/' why do you insist on supporting cpu_core/cycles/ ? jirka