From: Greg Kroah-Hartman <email@example.com> To: Michal Hocko <firstname.lastname@example.org> Cc: Kees Cook <email@example.com>, Andrew Morton <firstname.lastname@example.org>, Alexey Dobriyan <email@example.com>, Lee Duncan <firstname.lastname@example.org>, Chris Leech <email@example.com>, Adam Nichols <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, Uladzislau Rezki <firstname.lastname@example.org> Subject: Re: [PATCH v2] seq_file: Unconditionally use vmalloc for buffer Date: Wed, 17 Mar 2021 15:56:44 +0100 [thread overview] Message-ID: <YFIYrMVTC42boZ/Z@kroah.com> (raw) In-Reply-To: <YFIVwPWTo48ITkHs@dhcp22.suse.cz> On Wed, Mar 17, 2021 at 03:44:16PM +0100, Michal Hocko wrote: > On Wed 17-03-21 14:34:27, Greg KH wrote: > > On Wed, Mar 17, 2021 at 01:08:21PM +0100, Michal Hocko wrote: > > > Btw. I still have problems with the approach. seq_file is intended to > > > provide safe way to dump values to the userspace. Sacrificing > > > performance just because of some abuser seems like a wrong way to go as > > > Al pointed out earlier. Can we simply stop the abuse and disallow to > > > manipulate the buffer directly? I do realize this might be more tricky > > > for reasons mentioned in other emails but this is definitely worth > > > doing. > > > > We have to provide a buffer to "write into" somehow, so what is the best > > way to stop "abuse" like this? > > What is wrong about using seq_* interface directly? Right now every show() callback of sysfs would have to be changed :( > > Right now, we do have helper functions, sysfs_emit(), that know to stop > > the overflow of the buffer size, but porting the whole kernel to them is > > going to take a bunch of churn, for almost no real benefit except a > > potential random driver that might be doing bad things here that we have > > not noticed yet. > > I am not familiar with sysfs, I just got lost in all the indirection but > replacing buffer by the seq_file and operate on that should be possible, > no? sysfs files should be very simple and easy, and have a single value being written to userspace. I guess seq_printf() does handle the issue of "big buffers", but there should not be a big buffer here to worry about in the first place (yes, there was a bug where a driver took unchecked data and sent it to userspace overflowing the buffer which started this whole thread...) I guess Kees wants to change all show functions to use the seq_ api, which now makes a bit more sense, but still seems like a huge overkill. But I now understand the idea here, the buffer management is handled by the core kernel and overflows are impossible. A "simpler" fix is to keep the api the same today, and just "force" everyone to use sysfs_emit() which does the length checking automatically. I don't know, it all depends on how much effort we want to put into the "drivers can not do stupid things because we prevent them from it" type of work here... thanks, greg k-h
next prev parent reply other threads:[~2021-03-17 15:54 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-15 17:48 Kees Cook 2021-03-15 18:33 ` Al Viro 2021-03-15 20:43 ` Kees Cook 2021-03-16 7:24 ` Greg Kroah-Hartman 2021-03-16 12:43 ` Al Viro 2021-03-16 12:55 ` Greg Kroah-Hartman 2021-03-16 13:01 ` Michal Hocko 2021-03-16 19:18 ` Kees Cook 2021-03-17 10:44 ` Greg Kroah-Hartman 2021-03-16 8:31 ` Michal Hocko 2021-03-16 19:08 ` Kees Cook 2021-03-17 12:08 ` Michal Hocko 2021-03-17 13:34 ` Greg Kroah-Hartman 2021-03-17 14:44 ` Michal Hocko 2021-03-17 14:56 ` Greg Kroah-Hartman [this message] 2021-03-17 15:20 ` Michal Hocko 2021-03-17 15:38 ` Greg Kroah-Hartman 2021-03-17 15:48 ` Michal Hocko 2021-03-17 21:30 ` Kees Cook 2021-03-18 8:07 ` Greg Kroah-Hartman 2021-03-18 15:51 ` Kees Cook 2021-03-18 17:56 ` Greg Kroah-Hartman 2021-03-19 14:07 ` [seq_file] 5fd6060e50: stress-ng.eventfd.ops_per_sec -49.1% regression kernel test robot 2021-03-19 19:31 ` Kees Cook
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YFIYrMVTC42boZ/Z@kroah.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v2] seq_file: Unconditionally use vmalloc for buffer' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).