From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Badhri Jagan Sridharan <badhri@google.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] usb: typec: tcpci: Added few missing TCPCI register definitions
Date: Wed, 17 Mar 2021 19:03:02 +0100 [thread overview]
Message-ID: <YFJEVjRCLsnJ3/hg@kroah.com> (raw)
In-Reply-To: <9d8747e0-c23a-6dd2-8cd8-fbbc0501d673@roeck-us.net>
On Wed, Mar 17, 2021 at 10:58:24AM -0700, Guenter Roeck wrote:
> On 3/17/21 9:42 AM, Greg Kroah-Hartman wrote:
> > On Tue, Mar 16, 2021 at 03:52:58PM -0700, Guenter Roeck wrote:
> >> On 3/16/21 3:13 PM, Badhri Jagan Sridharan wrote:
> >>> This change adds some of the register bit definitions from the TCPCI spec:
> >>> https://www.usb.org/sites/default/files/documents/
> >>> usb-port_controller_specification_rev2.0_v1.0_0.pdf
> >>>
> >>> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
> >>
> >> Are those going to be used ?
> >
> > For values and #defines that are in public specs, does it matter? It's
> > good to have full definitions in the .h files for whenever possible for
> > stuff like this to make it easy for people to write code to use them :)
> >
>
> Good to know your position on this. It is one of the per-maintainer
> thingies: Some maintainers don't accept defines if they are not used.
> Usually I stay away from defining them to avoid the resulting arguments/
> discussions. If you are ok with it, so am I.
#defines are trivial, and are good for documenting things. We have loads
of drivers that do this to make it a good way to document the full
hardware or specification despite not using all of the defines. They
also are not a maintenance burden.
I don't take new apis that no one uses in-kernel as that's just ripe for
deletion and is a maintenance burden. It makes no sense to add and then
remove something right away :)
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-17 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 22:13 [PATCH v1] usb: typec: tcpci: Added few missing TCPCI register definitions Badhri Jagan Sridharan
2021-03-16 22:52 ` Guenter Roeck
2021-03-17 16:42 ` Greg Kroah-Hartman
2021-03-17 17:58 ` Guenter Roeck
2021-03-17 18:03 ` Greg Kroah-Hartman [this message]
2021-03-17 19:20 ` Guenter Roeck
2021-03-18 7:41 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFJEVjRCLsnJ3/hg@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=badhri@google.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).