From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEB73C433DB for ; Thu, 18 Mar 2021 14:12:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACC3A64E20 for ; Thu, 18 Mar 2021 14:12:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230224AbhCROLm (ORCPT ); Thu, 18 Mar 2021 10:11:42 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:37779 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbhCROLK (ORCPT ); Thu, 18 Mar 2021 10:11:10 -0400 X-Originating-IP: 90.65.108.55 Received: from localhost (lfbn-lyo-1-1676-55.w90-65.abo.wanadoo.fr [90.65.108.55]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 42A7DFF81E; Thu, 18 Mar 2021 14:11:03 +0000 (UTC) Date: Thu, 18 Mar 2021 15:11:03 +0100 From: Alexandre Belloni To: 'w00385741 Cc: Kishon Vijay Abraham I , Vinod Koul , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Bjarni Jonasson , Andrew Lunn , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot Subject: Re: [PATCH -next] phy: sparx5_serdes: Fix return value check in sparx5_serdes_probe() Message-ID: References: <20210318135647.1286295-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210318135647.1286295-1-weiyongjun1@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 18/03/2021 13:56:47+0000, 'w00385741 wrote: > From: Wei Yongjun > > In case of error, the function devm_ioremap() returns NULL > pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test. > > Fixes: 2ff8a1eeb5aa ("phy: Add Sparx5 ethernet serdes PHY driver") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/phy/microchip/sparx5_serdes.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/microchip/sparx5_serdes.c b/drivers/phy/microchip/sparx5_serdes.c > index 06bcf0c166cf..dd854d825000 100644 > --- a/drivers/phy/microchip/sparx5_serdes.c > +++ b/drivers/phy/microchip/sparx5_serdes.c > @@ -2438,10 +2438,10 @@ static int sparx5_serdes_probe(struct platform_device *pdev) > > iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); > iomem = devm_ioremap(priv->dev, iores->start, iores->end - iores->start + 1); > - if (IS_ERR(iomem)) { > + if (!iomem) { > dev_err(priv->dev, "Unable to get serdes registers: %s\n", > iores->name); > - return PTR_ERR(iomem); > + return -ENOMEM; > } A better fix would use devm_platform_ioremap_resource and get rid of the error messages > for (idx = 0; idx < ARRAY_SIZE(sparx5_serdes_iomap); idx++) { > struct sparx5_serdes_io_resource *iomap = &sparx5_serdes_iomap[idx]; > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com