From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C688EC433E0 for ; Fri, 19 Mar 2021 05:36:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9485864F59 for ; Fri, 19 Mar 2021 05:36:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233844AbhCSFf6 (ORCPT ); Fri, 19 Mar 2021 01:35:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231787AbhCSFfb (ORCPT ); Fri, 19 Mar 2021 01:35:31 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD699C06174A for ; Thu, 18 Mar 2021 22:35:31 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id ga23-20020a17090b0397b02900c0b81bbcd4so6199092pjb.0 for ; Thu, 18 Mar 2021 22:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=l9qdRJ37wMwErzIyw0U24u0NyMPwPyp/2vqA1Tx+4xY=; b=Ik1ukPvKh934dddyz6yPqKEoRi3+kqch9hVoWuFoPorP3AB6p+MKJKdkNT43KJL4SN /P9ojVXrng3BziRdMvsU9mWYICjpUS0DyrGYRhQ3TjMxv0mD5zF9HFbtTe8o83/ADKvT u5LkiAQPevSUh5Y0KeyAi33NoB9J0NJSOoSAM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=l9qdRJ37wMwErzIyw0U24u0NyMPwPyp/2vqA1Tx+4xY=; b=JBVjJPeuG9/HC5MdBmiivRHgfAAqhwVr6SBQ3draWk8NuuZ9Hn9FgUqyjL1lSmP379 MMwvHdeDT3L1T/+A5GeIVQbu1/XkNAQHA2jF+R2hSHciDLRiCnHpwG6OjOCcj+4GmRCy DBt4d4ki3MT9pfOfr1zYFP8HiDmxgWBs+QwT+7jh2BS6keS58A5fwWV53UoUIjpKTvAj c0Pbe8PeTrE2DD+uIxjDUXYX3KUmpeK5U9Gq4BBUNDMOvn74ThsSGHR/AwtXMkrbSgP1 5xqGgQsyjfSHjm4j8R/ISwCYzw/g0tL/0v7FagJxxohJRPbzi6cRDKNXUv3sunBAgeYm Etkg== X-Gm-Message-State: AOAM533AtWw9tYYoEHyQBSwltBEpZ5978xvSTe+b5TZM70L5qM7ysit4 oB5Smx9ufa3bw47nqDqxlYMjhg== X-Google-Smtp-Source: ABdhPJwEoH4kXmBWJFvyEEPTHu0ycUeMmF/84wCTY8Yp0+t1W38oAFNb1AUIu7W/mR/hE3AsRP0FAw== X-Received: by 2002:a17:90a:f40c:: with SMTP id ch12mr8038514pjb.176.1616132131240; Thu, 18 Mar 2021 22:35:31 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:6577:f83d:5865:dfac]) by smtp.gmail.com with ESMTPSA id fr23sm3892636pjb.22.2021.03.18.22.35.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 22:35:30 -0700 (PDT) Date: Fri, 19 Mar 2021 14:35:26 +0900 From: Sergey Senozhatsky To: Ricardo Ribalda Cc: Ricardo Ribalda Delgado , Laurent Pinchart , Tomasz Figa , Mauro Carvalho Chehab , linux-media , LKML , Sergey Senozhatsky Subject: Re: [PATCHv2 3/3] media: uvcvideo: add UVC 1.5 ROI control Message-ID: References: <20210208051749.1785246-1-sergey.senozhatsky@gmail.com> <20210208051749.1785246-4-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (21/03/18 22:19), Ricardo Ribalda wrote: > > > > May I please ask for more opinions on this? > > Could you try setting the roi in a loop in your device and verify that > it accepts all the values with no modification. If so we can implement > the set/get as a quirk for other devices. Tested on two (very) different devices. Firmware D: CLAP all passed, we are cool Firmware H: CLAP all passed, we are cool Code sample --- in_selection.target = V4L2_SEL_TGT_ROI; in_selection.flags = V4L2_SEL_FLAG_ROI_AUTO_EXPOSURE; for (int i = 0; i < 1001; i++) { in_selection.r.left = 0 + i; in_selection.r.top = 0 + i; in_selection.r.width = 42 + i; in_selection.r.height = 42 + i; ret = doioctl(fd, VIDIOC_S_SELECTION, &in_selection); if (ret) { fprintf(stderr, "BOOM %d\n", ret); exit(1); } ret = doioctl(fd, VIDIOC_G_SELECTION, &in_selection); if (ret) { fprintf(stderr, "BANG %d\n", ret); exit(2); } if (in_selection.r.left != i || in_selection.r.top != i || in_selection.r.width != i + 42 || in_selection.r.height != i + 42) { fprintf(stderr, "SNAP %d %d %d %d != %d %d %d %d\n", i, i, i + 42, i + 42, in_selection.r.left, in_selection.r.top, in_selection.r.width, in_selection.r.height); exit(3); } } fprintf(stderr, "CLAP all passed, we are cool\n"); ---