From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A7CEC433DB for ; Fri, 19 Mar 2021 13:24:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DC3064F04 for ; Fri, 19 Mar 2021 13:24:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229967AbhCSNXn (ORCPT ); Fri, 19 Mar 2021 09:23:43 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37120 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229805AbhCSNXd (ORCPT ); Fri, 19 Mar 2021 09:23:33 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lNF69-00BtB8-BQ; Fri, 19 Mar 2021 14:23:29 +0100 Date: Fri, 19 Mar 2021 14:23:29 +0100 From: Andrew Lunn To: Asmaa Mnebhi Cc: "linus.walleij@linaro.org" , "bgolaszewski@baylibre.com" , David Thompson , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" Subject: Re: [PATCH v1 1/1] gpio: Support interrupts in gpio-mlxbf2.c Message-ID: References: <1614120685-7452-1-git-send-email-Asmaa@mellanox.com> <1614120685-7452-2-git-send-email-Asmaa@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > We cannot really pass it through the ACPI table because the ACPI > table is common to all BlueField-2 boards. And each board may have > a different GPIO pin associated with a particular function. This is > why we use ACPI properties instead of GpioInt(). So that the > bootloader can change the GPIO pin value based on the board id > detected at boot time. That sounds very broken. ACPI describes the hardware. If the hardware is different, you need different ACPI. And i assume the ACPI spec says GpioInt() is the correct way to do this, and does not say you can hack around limitations of your bootloader using properties? Andrew