From: Petr Mladek <pmladek@suse.com>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: willy@infradead.org, andriy.shevchenko@linux.intel.com,
david@redhat.com, linmiaohe@huawei.com, vbabka@suse.cz,
cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
rostedt@goodmis.org, sergey.senozhatsky@gmail.com,
joe@perches.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, lkp@intel.com
Subject: Re: [PATCH v6 resend 3/3] vsprintf: dump full information of page flags in pGp
Date: Fri, 19 Mar 2021 16:27:03 +0100 [thread overview]
Message-ID: <YFTCxyhssX33R1k6@alley> (raw)
In-Reply-To: <20210319101246.73513-4-laoar.shao@gmail.com>
On Fri 2021-03-19 18:12:46, Yafang Shao wrote:
> Currently the pGp only shows the names of page flags, rather than
> the full information including section, node, zone, last cpupid and
> kasan tag. While it is not easy to parse these information manually
> because there're so many flavors. Let's interpret them in pGp as well.
>
> To be compitable with the existed format of pGp, the new introduced ones
> also use '|' as the separator, then the user tools parsing pGp won't
> need to make change, suggested by Matthew. The new information is
> tracked onto the end of the existed one.
>
> On example of the output in mm/slub.c as follows,
> - Before the patch,
> [ 6343.396602] Slab 0x000000004382e02b objects=33 used=3 fp=0x000000009ae06ffc flags=0x17ffffc0010200(slab|head)
>
> - After the patch,
> [ 8448.272530] Slab 0x0000000090797883 objects=33 used=3 fp=0x00000000790f1c26 flags=0x17ffffc0010200(slab|head|node=0|zone=2|lastcpupid=0x1fffff)
>
> The documentation and test cases are also updated. The output of the
> test cases as follows,
> [68599.816764] test_printf: loaded.
> [68599.819068] test_printf: all 388 tests passed
> [68599.830367] test_printf: unloaded.
>
> [lkp@intel.com: reported issues in the prev version in test_printf.c]
>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
It looks good. And it seems that the selftest should not longer have
that problems on various architectures and configurations.
I am going to push it.
Best Regards,
Petr
next prev parent reply other threads:[~2021-03-19 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 10:12 [PATCH v6 resend 0/3] mm, vsprintf: dump full information of page flags in pGp Yafang Shao
2021-03-19 10:12 ` [PATCH v6 resend 1/3] mm, slub: use pGp to print page flags Yafang Shao
2021-03-19 10:12 ` [PATCH v6 resend 2/3] mm, slub: don't combine pr_err with INFO Yafang Shao
2021-03-19 10:12 ` [PATCH v6 resend 3/3] vsprintf: dump full information of page flags in pGp Yafang Shao
2021-03-19 15:27 ` Petr Mladek [this message]
2021-03-19 10:15 ` [PATCH v6 resend 0/3] mm, " Yafang Shao
2021-03-19 12:22 ` Petr Mladek
2021-03-19 15:03 ` Sergey Senozhatsky
2021-03-19 16:05 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFTCxyhssX33R1k6@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=laoar.shao@gmail.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).