From: Andrew Lunn <andrew@lunn.ch>
To: Alex Elder <elder@linaro.org>
Cc: davem@davemloft.net, kuba@kernel.org, bjorn.andersson@linaro.org,
evgreen@chromium.org, cpratapa@codeaurora.org, elder@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/4] net: ipa: activate some commented assertions
Date: Fri, 19 Mar 2021 19:32:31 +0100 [thread overview]
Message-ID: <YFTuP7NbUFPoPoCb@lunn.ch> (raw)
In-Reply-To: <20210319042923.1584593-5-elder@linaro.org>
> @@ -212,7 +213,7 @@ static inline u32 ipa_reg_bcr_val(enum ipa_version version)
> BCR_HOLB_DROP_L2_IRQ_FMASK |
> BCR_DUAL_TX_FMASK;
>
> - /* assert(version != IPA_VERSION_4_5); */
> + ipa_assert(NULL, version != IPA_VERSION_4_5);
Hi Alex
It is impossible to see just looking what the NULL means. And given
its the first parameter, it should be quite important. I find this API
pretty bad.
Andrew
next prev parent reply other threads:[~2021-03-19 18:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 4:29 [PATCH net-next 0/4] net: ipa: fix validation Alex Elder
2021-03-19 4:29 ` [PATCH net-next 1/4] net: ipa: fix init header command validation Alex Elder
2021-03-19 4:29 ` [PATCH net-next 2/4] net: ipa: fix IPA validation Alex Elder
2021-03-19 4:29 ` [PATCH net-next 3/4] net: ipa: introduce ipa_assert() Alex Elder
2021-03-19 4:55 ` Leon Romanovsky
2021-03-19 12:38 ` Alex Elder
2021-03-19 15:32 ` Leon Romanovsky
2021-03-19 16:01 ` Alex Elder
2021-03-19 18:20 ` Andrew Lunn
2021-03-19 4:29 ` [PATCH net-next 4/4] net: ipa: activate some commented assertions Alex Elder
2021-03-19 5:00 ` Leon Romanovsky
2021-03-19 12:40 ` Alex Elder
2021-03-19 15:17 ` Leon Romanovsky
2021-03-19 15:32 ` Alex Elder
2021-03-19 18:32 ` Andrew Lunn [this message]
2021-03-19 21:18 ` Alex Elder
2021-03-19 21:30 ` Andrew Lunn
2021-03-20 13:24 ` [PATCH net-next 0/4] net: ipa: fix validation Alex Elder
2021-03-20 14:23 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFTuP7NbUFPoPoCb@lunn.ch \
--to=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=elder@linaro.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).