From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 988F5C433E2 for ; Fri, 19 Mar 2021 18:33:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5520161985 for ; Fri, 19 Mar 2021 18:33:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230363AbhCSSdF (ORCPT ); Fri, 19 Mar 2021 14:33:05 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37636 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230264AbhCSSci (ORCPT ); Fri, 19 Mar 2021 14:32:38 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lNJvD-00BvQJ-Pz; Fri, 19 Mar 2021 19:32:31 +0100 Date: Fri, 19 Mar 2021 19:32:31 +0100 From: Andrew Lunn To: Alex Elder Cc: davem@davemloft.net, kuba@kernel.org, bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 4/4] net: ipa: activate some commented assertions Message-ID: References: <20210319042923.1584593-1-elder@linaro.org> <20210319042923.1584593-5-elder@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210319042923.1584593-5-elder@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -212,7 +213,7 @@ static inline u32 ipa_reg_bcr_val(enum ipa_version version) > BCR_HOLB_DROP_L2_IRQ_FMASK | > BCR_DUAL_TX_FMASK; > > - /* assert(version != IPA_VERSION_4_5); */ > + ipa_assert(NULL, version != IPA_VERSION_4_5); Hi Alex It is impossible to see just looking what the NULL means. And given its the first parameter, it should be quite important. I find this API pretty bad. Andrew