From: Ansuel Smith <ansuelsmth@gmail.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Miguel Ojeda <ojeda@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] clang-format: Update ColumnLimit
Date: Fri, 19 Mar 2021 19:45:13 +0100 [thread overview]
Message-ID: <YFTxOcf56lPBi2sb@Ansuel-xps.localdomain> (raw)
In-Reply-To: <20210319184234.jsudy6solmtrq6vz@archlinux-ax161>
On Fri, Mar 19, 2021 at 11:42:34AM -0700, Nathan Chancellor wrote:
> On Fri, Mar 19, 2021 at 07:37:14PM +0100, Ansuel Smith wrote:
> > Update ColumnLimit value, changed from 80 to 100.
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
> > .clang-format | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/.clang-format b/.clang-format
> > index c24b147cac01..3212542df113 100644
> > --- a/.clang-format
> > +++ b/.clang-format
> > @@ -52,7 +52,7 @@ BreakConstructorInitializersBeforeComma: false
> > #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0
> > BreakAfterJavaFieldAnnotations: false
> > BreakStringLiterals: false
> > -ColumnLimit: 80
> > +ColumnLimit: 100
> > CommentPragmas: '^ IWYU pragma:'
> > #CompactNamespaces: false # Unknown to clang-format-4.0
> > ConstructorInitializerAllOnOneLineOrOnePerLine: false
> > --
> > 2.30.2
> >
>
> Not sure how opinions have changed since but this has come up before:
>
> https://lore.kernel.org/r/20200610125147.2782142-1-christian.brauner@ubuntu.com/
>
Sorry, didn't notice that. Considering that checkpatch complains and
some reviewers actually state that 100 is the new limit, I think it's
time to update the file.
> Cheers,
> Nathan
next prev parent reply other threads:[~2021-03-19 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 18:37 [PATCH] clang-format: Update ColumnLimit Ansuel Smith
2021-03-19 18:42 ` Nathan Chancellor
2021-03-19 18:45 ` Ansuel Smith [this message]
2021-03-19 18:48 ` Miguel Ojeda
2021-03-20 4:56 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFTxOcf56lPBi2sb@Ansuel-xps.localdomain \
--to=ansuelsmth@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).