Re: [PATCH net-next v2 0/2] net: ipa: fix validation

From: Leon Romanovsky <leon@kernel.org>
To: Alex Elder <elder@linaro.org>
Cc: davem@davemloft.net, kuba@kernel.org, andrew@lunn.ch,
	bjorn.andersson@linaro.org, evgreen@chromium.org,
	cpratapa@codeaurora.org, subashab@codeaurora.org,
	elder@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/2] net: ipa: fix validation
Date: Mon, 22 Mar 2021 16:16:02 +0200	[thread overview]
Message-ID: <YFimooGgT1pIRe/G@unreal> (raw)
In-Reply-To: <f1b719d3-c7f2-1815-9cfe-19ea23944cce@linaro.org>

On Mon, Mar 22, 2021 at 08:22:20AM -0500, Alex Elder wrote:
> On 3/20/21 9:17 AM, Alex Elder wrote:
> > There is sanity checking code in the IPA driver that's meant to be
> > enabled only during development.  This allows the driver to make
> > certain assumptions, but not have to verify those assumptions are
> > true at (operational) runtime.  This code is built conditional on
> > IPA_VALIDATION, set (if desired) inside the IPA makefile.
> > 
> > Unfortunately, this validation code has some errors.  First, there
> > are some mismatched arguments supplied to some dev_err() calls in
> > ipa_cmd_table_valid() and ipa_cmd_header_valid(), and these are
> > exposed if validation is enabled.  Second, the tag that enables
> > this conditional code isn't used consistently (it's IPA_VALIDATE
> > in some spots and IPA_VALIDATION in others).
> > 
> > This series fixes those two problems with the conditional validation
> > code.
> 
> After much back-and-forth with Leon Romanovsky:
> 
> 	--> I retract this series <--
> 
> I will include these patches in a future series that will
> do cleanup of this validation code more completely.

Thanks a lot.

> 
> Thanks.
> 
> 					-Alex
> 
> > Version 2 removes the two patches that introduced ipa_assert().  It
> > also modifies the description in the first patch so that it mentions
> > the changes made to ipa_cmd_table_valid().
> > 
> > 					-Alex
> > 
> > Alex Elder (2):
> >    net: ipa: fix init header command validation
> >    net: ipa: fix IPA validation
> > 
> >   drivers/net/ipa/Makefile       |  2 +-
> >   drivers/net/ipa/gsi_trans.c    |  8 ++---
> >   drivers/net/ipa/ipa_cmd.c      | 54 ++++++++++++++++++++++------------
> >   drivers/net/ipa/ipa_cmd.h      |  6 ++--
> >   drivers/net/ipa/ipa_endpoint.c |  6 ++--
> >   drivers/net/ipa/ipa_main.c     |  6 ++--
> >   drivers/net/ipa/ipa_mem.c      |  6 ++--
> >   drivers/net/ipa/ipa_table.c    |  6 ++--
> >   drivers/net/ipa/ipa_table.h    |  6 ++--
> >   9 files changed, 58 insertions(+), 42 deletions(-)
> > 
> 