From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E6E6C433C1 for ; Mon, 22 Mar 2021 16:12:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0443861974 for ; Mon, 22 Mar 2021 16:12:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231580AbhCVQLn (ORCPT ); Mon, 22 Mar 2021 12:11:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:55944 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230002AbhCVQLQ (ORCPT ); Mon, 22 Mar 2021 12:11:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 40D1E61974; Mon, 22 Mar 2021 16:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616429475; bh=uXWzdJao91erGlT0gjrKYueZuvbCNU6HdOT0WlaF5yM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CEnzfShKpZ2/pZOcNP/XY/SJVhKtnYD0qkwdfM9k86Gkx37aPGO69jshLHe4dn9Lg J2HxkOUpDIr+SgybbHXxZ/YVlbhc/C6tyZI9vxI5dW4607Ohk4b61TMLVTdaZQ6pos wBNMYjhhrqidz/uW9WlAo7fm7f6RGISOFMLu/fKo= Date: Mon, 22 Mar 2021 17:11:13 +0100 From: Greg KH To: Fabio Aiuto Cc: joe@perches.com, apw@canonical.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/11] staging: rtl8723bs: remove argument in recv_indicatepkts_pkt_loss_cnt Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 22, 2021 at 03:31:43PM +0100, Fabio Aiuto wrote: > remove debug_priv argument so function prototype can be > easily moved away > > Signed-off-by: Fabio Aiuto > --- > drivers/staging/rtl8723bs/core/rtw_recv.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c > index 9ef2408ded57..e2a6afed723c 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_recv.c > +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c > @@ -1983,13 +1983,13 @@ int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, union rec > > } > > -void recv_indicatepkts_pkt_loss_cnt(struct debug_priv *pdbgpriv, u64 prev_seq, u64 current_seq); > -void recv_indicatepkts_pkt_loss_cnt(struct debug_priv *pdbgpriv, u64 prev_seq, u64 current_seq) > +u64 recv_indicatepkts_pkt_loss_cnt(u64 prev_seq, u64 current_seq); But you did not drop the function prototype, why keep it? And shouldn't this be static? thanks, greg k-h