From: Mike Rapoport <rppt@linux.ibm.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-man@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Andrea Arcangeli <aarcange@redhat.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Axel Rasmussen <axelrasmussen@google.com>,
Alejandro Colomar <alx.manpages@gmail.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Nadav Amit <nadav.amit@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v4 0/4] man2: udpate mm/userfaultfd manpages to latest
Date: Tue, 23 Mar 2021 10:31:31 +0200 [thread overview]
Message-ID: <YFmnYxrfz3qAzfR9@linux.ibm.com> (raw)
In-Reply-To: <20210322220848.52162-1-peterx@redhat.com>
On Mon, Mar 22, 2021 at 06:08:44PM -0400, Peter Xu wrote:
> v4:
> - Fixed a few "subordinate clauses" (SC) cases [Alex]
> - Reword in ioctl_userfaultfd.2 to use bold font for the two modes referenced,
> so as to be clear on what is "both" referring to [Alex]
>
> v3:
> - Don't use "Currently", instead add "(since x.y)" mark where proper [Alex]
> - Always use semantic newlines across the whole patchset [Alex]
> - Use quote when possible, rather than escapes [Alex]
> - Fix one missing replacement of ".BR" -> ".B" [Alex]
> - Some other trivial rephrases here and there when fixing up above
>
> v2 changes:
> - Fix wordings as suggested [MikeR]
> - convert ".BR" to ".B" where proper for the patchset [Alex]
> - rearrange a few lines in the last two patches where they got messed up
> - document more things, e.g. UFFDIO_COPY_MODE_WP; and also on how to resolve a
> wr-protect page fault.
>
> There're two features missing in current manpage, namely:
>
> (1) Userfaultfd Thread-ID feature
> (2) Userfaultfd write protect mode
>
> There's also a 3rd one which was just contributed from Axel - Axel, I think it
> would be great if you can add that part too, probably after the whole
> hugetlbfs/shmem minor mode reaches the linux master branch.
>
> Please review, thanks.
>
> Peter Xu (4):
> userfaultfd.2: Add UFFD_FEATURE_THREAD_ID docs
> userfaultfd.2: Add write-protect mode
> ioctl_userfaultfd.2: Add UFFD_FEATURE_THREAD_ID docs
> ioctl_userfaultfd.2: Add write-protect mode docs
>
> man2/ioctl_userfaultfd.2 | 89 ++++++++++++++++++++++++++++-
> man2/userfaultfd.2 | 117 ++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 201 insertions(+), 5 deletions(-)
Acked-by: Mike Rapoport <rppt@linux.ibm.com>
> --
> 2.26.2
>
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2021-03-23 8:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 22:08 [PATCH v4 0/4] man2: udpate mm/userfaultfd manpages to latest Peter Xu
2021-03-22 22:08 ` [PATCH v4 1/4] userfaultfd.2: Add UFFD_FEATURE_THREAD_ID docs Peter Xu
2021-03-23 8:27 ` Mike Rapoport
2021-03-23 15:17 ` Peter Xu
2021-03-22 22:08 ` [PATCH v4 2/4] userfaultfd.2: Add write-protect mode Peter Xu
2021-03-23 18:19 ` Alejandro Colomar (man-pages)
2021-03-23 18:58 ` Peter Xu
2021-03-22 22:08 ` [PATCH v4 3/4] ioctl_userfaultfd.2: Add UFFD_FEATURE_THREAD_ID docs Peter Xu
2021-03-22 22:08 ` [PATCH v4 4/4] ioctl_userfaultfd.2: Add write-protect mode docs Peter Xu
2021-03-23 18:11 ` Alejandro Colomar (man-pages)
2021-03-23 19:16 ` Peter Xu
2021-03-25 21:32 ` Alejandro Colomar (man-pages)
2021-03-29 21:51 ` Peter Xu
2021-03-29 22:05 ` Alejandro Colomar (man-pages)
2021-03-23 8:31 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFmnYxrfz3qAzfR9@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alx.manpages@gmail.com \
--cc=axelrasmussen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mtk.manpages@gmail.com \
--cc=nadav.amit@gmail.com \
--cc=peterx@redhat.com \
--cc=rppt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).