From: Leon Romanovsky <leon@kernel.org>
To: Yejune Deng <yejune.deng@gmail.com>
Cc: David Miller <davem@davemloft.net>,
yoshfuji@linux-ipv6.org, dsahern@kernel.org,
Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
yejune@gmail.com
Subject: Re: [PATCH 1/2] net: ipv4: route.c: add likely() statements
Date: Wed, 24 Mar 2021 14:19:32 +0200 [thread overview]
Message-ID: <YFsuVDncNFiuonSx@unreal> (raw)
In-Reply-To: <CABWKuGUPkMHZj6qsAYmCnc==4pP8vyYK-3TRJ9oG8mk=nJBLAw@mail.gmail.com>
On Wed, Mar 24, 2021 at 07:01:19PM +0800, Yejune Deng wrote:
> My reasons are as following: ipv4_confirm_neigh() belongs to
> ipv4_dst_ops that family is AF_INET, and ipv4_neigh_lookup() is also
> added likely() when rt->rt_gw_family is equal to AF_INET.
It is part of that cargo cult. Please support your claim with
performance numbers when this likely/unlikely will give any difference.
Thanks
>
> On Wed, Mar 24, 2021 at 6:34 PM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > On Wed, Mar 24, 2021 at 11:09:22AM +0800, Yejune Deng wrote:
> > > Add likely() statements in ipv4_confirm_neigh() for 'rt->rt_gw_family
> > > == AF_INET'.
> >
> > Why? Such macros are beneficial in only specific cases, most of the time,
> > likely/unlikely is cargo cult.
> >
> > >
> > > Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
> > > ---
> > > net/ipv4/route.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> > > index fa68c2612252..5762d9bc671c 100644
> > > --- a/net/ipv4/route.c
> > > +++ b/net/ipv4/route.c
> > > @@ -440,7 +440,7 @@ static void ipv4_confirm_neigh(const struct dst_entry *dst, const void *daddr)
> > > struct net_device *dev = dst->dev;
> > > const __be32 *pkey = daddr;
> > >
> > > - if (rt->rt_gw_family == AF_INET) {
> > > + if (likely(rt->rt_gw_family == AF_INET)) {
> > > pkey = (const __be32 *)&rt->rt_gw4;
> > > } else if (rt->rt_gw_family == AF_INET6) {
> > > return __ipv6_confirm_neigh_stub(dev, &rt->rt_gw6);
> > > --
> > > 2.29.0
> > >
prev parent reply other threads:[~2021-03-24 12:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 3:09 [PATCH 1/2] net: ipv4: route.c: add likely() statements Yejune Deng
2021-03-24 10:34 ` Leon Romanovsky
2021-03-24 11:01 ` Yejune Deng
2021-03-24 12:19 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFsuVDncNFiuonSx@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yejune.deng@gmail.com \
--cc=yejune@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).