From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12625C433E1 for ; Wed, 24 Mar 2021 14:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC14061A1C for ; Wed, 24 Mar 2021 14:20:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236117AbhCXOT7 (ORCPT ); Wed, 24 Mar 2021 10:19:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:33558 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236029AbhCXOTt (ORCPT ); Wed, 24 Mar 2021 10:19:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C374C619D5; Wed, 24 Mar 2021 14:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616595589; bh=SqJk8IkxfEpl+NF3dJR2+tt7AFBJle3tFmyyydCRxDU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nsxBwiu820tX1DJ0Kt8I8l8D6Y9bGBu3wL9etC2Puv9mn5tMB/VluzKlms7udel5I NecOfzGbJHCrgxjZGSnliPxEI9eRNbf+FWGwBGllBupQP8w1PYTQeMLKAK/ASVI24U DjAbdn8MZ60wIwzRRJKkJrA1rlSg37yE/9/LpyfBnxqtw+/HOAdxDbGyodmscgRIYa LVctF9egU5hh8BUdgGMxEroBJrMzbOjLK6+H0PqVwHsBCcq2vZ1aEztgdH4crKwwfB 5Uo0F3KRh6EZISwWHy7P2E3mUBqvtrrh6loD7rw91dAqOg+oGJlPp2l87ShgPn8vMB WrEbkrz4ehC2A== Date: Wed, 24 Mar 2021 16:19:45 +0200 From: Leon Romanovsky To: YueHaibing Cc: bvanassche@acm.org, dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] IB/srpt: Fix passing zero to 'PTR_ERR' Message-ID: References: <20210324140939.7480-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210324140939.7480-1-yuehaibing@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 24, 2021 at 10:09:39PM +0800, YueHaibing wrote: > Fix smatch warning: > > drivers/infiniband/ulp/srpt/ib_srpt.c:2341 srpt_cm_req_recv() warn: passing zero to 'PTR_ERR' > > Use PTR_ERR_OR_ZERO instead of PTR_ERR > > Fixes: 847462de3a0a ("IB/srpt: Fix srpt_cm_req_recv() error path (1/2)") > Signed-off-by: YueHaibing > --- > drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c > index 6be60aa5ffe2..3ff24b5048ac 100644 > --- a/drivers/infiniband/ulp/srpt/ib_srpt.c > +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c > @@ -2338,7 +2338,7 @@ static int srpt_cm_req_recv(struct srpt_device *const sdev, > > if (IS_ERR_OR_NULL(ch->sess)) { > WARN_ON_ONCE(ch->sess == NULL); > - ret = PTR_ERR(ch->sess); > + ret = PTR_ERR_OR_ZERO(ch->sess); It is crazy, in first line, we checked ch->sess and allowed it to be NULL, later caused to kernel panic and set ret to success. > ch->sess = NULL; > pr_info("Rejected login for initiator %s: ret = %d.\n", > ch->sess_name, ret); > -- > 2.22.0 >