From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F5D7C433E1 for ; Wed, 24 Mar 2021 22:46:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FC3061A23 for ; Wed, 24 Mar 2021 22:46:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238898AbhCXWp4 (ORCPT ); Wed, 24 Mar 2021 18:45:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238880AbhCXWpl (ORCPT ); Wed, 24 Mar 2021 18:45:41 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 543D8C06175F for ; Wed, 24 Mar 2021 15:45:41 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id e33so15811550pgm.13 for ; Wed, 24 Mar 2021 15:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dtMAFNGRvXR9tr74ckEk4qdzC3+4Qmuoanh+5ep0zEg=; b=mf4RKQX2PTsWVXlghsyxe8tAq+NHBJ/XcntZttvk+RoykwKGf03PqYjgRaYZpuERLo VIohXueiLN9zcCGZPSrTApIF+OW7zXOcdCT1MpoXkImRUaU2+hCZY4DZrM89t2PQogRh vEGm4/gFGaIYg5t074wfc/a4z2rGcz7XeutUeBzVeETCWc9QcGEZJ+Kbm9ftykJCauqm n2tFBn61Oc7G8gnCx6SJhEthi4uVMiawT98MZtZjqlP276qdHJnFGUGOazmKpnlls/1e t+43rr6zgsOlt/SLhgbj9PpNTd5nCIbc+fPx+Pgl/x5I96C/fYxw8nFHk2jZfFHG5Y6E z/xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dtMAFNGRvXR9tr74ckEk4qdzC3+4Qmuoanh+5ep0zEg=; b=EwKKD67xg55A8poVZhig7rlZOsLYDZAzqzHU3GtX6J/I8G81Sls50V/slLVkcvJAgp cJTepK92zcynHM8uZVy1QDraXRTdKXD5fCTfsnlkWo85PngWbK5SOfv2Jm/QfehvRCPx wghp0tGWI01sj8Mu2ExyHp6UwXDZx2RPCNE+i3T2iIDpUmd+iSPqxz+moJBTMGPIXZn+ SRu3vCgzehnbcFe+KOYri4sdjJey0izLKAyeEkBDJfJHHJuqB5Y6uHUQr6yPCOqbZAvR C0NdaxRt7Uk/8JvJzyRiacDvrY/q6/f01RvOb0PJv3cOjLsg2UhiQp9pzuZ50+YRAXv+ MWLg== X-Gm-Message-State: AOAM532RusrWCBffTK1cn/RdErzkhcWmq1VFyEmJg/WipPok4zuPacaR 1TnOwB4I2SM4l4EMWxCrpMff4A== X-Google-Smtp-Source: ABdhPJx9tirFcs8M8z1akH8PiPcyfxRquA5Pe9ivMYrUey8HlclyG6nFMCckS2EuSyMG3lRCt2NS0w== X-Received: by 2002:a63:d704:: with SMTP id d4mr4751624pgg.221.1616625940704; Wed, 24 Mar 2021 15:45:40 -0700 (PDT) Received: from google.com (240.111.247.35.bc.googleusercontent.com. [35.247.111.240]) by smtp.gmail.com with ESMTPSA id l22sm3785879pfd.145.2021.03.24.15.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 15:45:40 -0700 (PDT) Date: Wed, 24 Mar 2021 22:45:36 +0000 From: Sean Christopherson To: Sami Tolvanen Cc: Masahiro Yamada , Michal Marek , Nathan Chancellor , Nick Desaulniers , linux-kbuild , LKML , clang-built-linux , Kees Cook Subject: Re: [PATCH] kbuild: Merge module sections if and only if CONFIG_LTO_CLANG is enabled Message-ID: References: <20210322234438.502582-1-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 23, 2021, Sami Tolvanen wrote: > On Tue, Mar 23, 2021 at 9:36 AM Sean Christopherson wrote: > > > > On Tue, Mar 23, 2021, Sami Tolvanen wrote: > > > On Mon, Mar 22, 2021 at 4:44 PM Sean Christopherson wrote: > > > > > > > > Merge module sections only when using Clang LTO. With gcc-10, merging > > > > sections does not appear to update the symbol tables for the module, > > > > e.g. 'readelf -s' shows the value that a symbol would have had, if > > > > sections were not merged. > > > > > > I'm fine with limiting this to LTO only, but it would be helpful to > > > understand which sections are actually getting merged here. > > > > It doesn't appear to matter which sections get merged, the tables only show the > > correct data if there is no merging whatsoever, e.g. allowing merging for any > > one of the four types (.bss, .data, .rodata and .text) results in breakage. > > AFAICT, merging any sections causes the layout to change and throw off the > > symbol tables. > > Thanks for the clarification. I can reproduce this issue with gcc + > bfd if any of the sections are merged, but gcc + lld produces valid > symbol tables. FWIW, clang + bfd also produces mangled tables, so it does appear to be bfd specific. > Perhaps someone more familiar with bfd can comment on whether this is > a bug or a feature, and if there's a flag we can pass to bfd that > would fix the issue. In the meanwhile, this patch looks like a > reasonable workaround to me. > > Reviewed-by: Sami Tolvanen > Tested-by: Sami Tolvanen > > Sami