From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B87E5C433B4 for ; Wed, 7 Apr 2021 15:07:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 821C96113D for ; Wed, 7 Apr 2021 15:07:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353359AbhDGPHb (ORCPT ); Wed, 7 Apr 2021 11:07:31 -0400 Received: from mga11.intel.com ([192.55.52.93]:41706 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242586AbhDGPH3 (ORCPT ); Wed, 7 Apr 2021 11:07:29 -0400 IronPort-SDR: uqt+0s0C/M44787dW2QEuIxYoYVBk4dz3nZf7R4RGvWk3jvb0AzmXbhwuLvD7WFOLwguR+XZCr oU2b5i5pt/kA== X-IronPort-AV: E=McAfee;i="6000,8403,9947"; a="190123293" X-IronPort-AV: E=Sophos;i="5.82,203,1613462400"; d="scan'208";a="190123293" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 08:07:19 -0700 IronPort-SDR: DoDEm7SOJomqulRq1VRGRBl1KuHBQIu9o8e/pOc5LbOmC/NuW4+Qm41Cf9B8Z173F84x8bhkqz qrl0Xe4m239Q== X-IronPort-AV: E=Sophos;i="5.82,203,1613462400"; d="scan'208";a="519469002" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 08:07:15 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lU9lw-0022JS-AH; Wed, 07 Apr 2021 18:07:12 +0300 Date: Wed, 7 Apr 2021 18:07:12 +0300 From: Andy Shevchenko To: Petr Mladek Cc: Stephen Boyd , Andrew Morton , linux-kernel@vger.kernel.org, Jiri Olsa , Alexei Starovoitov , Jessica Yu , Evan Green , Hsin-Yi Wang , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , linux-doc@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces Message-ID: References: <20210331030520.3816265-1-swboyd@chromium.org> <20210331030520.3816265-5-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 07, 2021 at 04:54:33PM +0200, Petr Mladek wrote: > On Tue 2021-03-30 20:05:12, Stephen Boyd wrote: > > Let's make kernel stacktraces easier to identify by including the build > > ID[1] of a module if the stacktrace is printing a symbol from a module. > > This makes it simpler for developers to locate a kernel module's full > > debuginfo for a particular stacktrace. Combined with > > scripts/decode_stracktrace.sh, a developer can download the matching > > debuginfo from a debuginfod[2] server and find the exact file and line > > number for the functions plus offsets in a stacktrace that match the > > module. This is especially useful for pstore crash debugging where the > > kernel crashes are recorded in something like console-ramoops and the > > recovery kernel/modules are different or the debuginfo doesn't exist on > > the device due to space concerns (the debuginfo can be too large for > > space limited devices). ... > It shows wrong build id for vmlinux. > And it does not show the build if for the module at all. >From your previous messages and this seems like virtualization breaks the access / use of build ID :-( -- With Best Regards, Andy Shevchenko