linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: min.li.xe@renesas.com
Cc: derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com,
	arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support
Date: Wed, 7 Apr 2021 19:48:40 +0200	[thread overview]
Message-ID: <YG3weJsOd2IZ5jRQ@kroah.com> (raw)
In-Reply-To: <1617816815-3785-2-git-send-email-min.li.xe@renesas.com>

On Wed, Apr 07, 2021 at 01:33:35PM -0400, min.li.xe@renesas.com wrote:
> +static int
> +rsmu_open(struct inode *iptr, struct file *fptr)
> +{
> +	return 0;
> +}
> +
> +static int
> +rsmu_release(struct inode *iptr, struct file *fptr)
> +{
> +	return 0;
> +}

If you do nothing in an open/release function, then there is no need to
have them at all, you can remove them.

But this feels odd, how do you know what device you are using in your
ioctl command?

thanks,

greg k-h

  parent reply	other threads:[~2021-04-07 17:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 17:33 [PATCH net-next v2 1/2] mfd: Add Renesas Synchronization Management Unit (SMU) support min.li.xe
2021-04-07 17:33 ` [PATCH net-next v2 2/2] misc: " min.li.xe
2021-04-07 17:45   ` Greg KH
2021-04-07 19:43     ` Min Li
2021-04-08  6:19       ` Greg KH
2021-04-08 19:40         ` Min Li
2021-04-07 17:47   ` Greg KH
2021-04-07 20:00     ` Min Li
2021-04-08  6:20       ` Greg KH
2021-04-07 17:48   ` Greg KH [this message]
2021-04-07 19:56     ` Min Li
2021-04-07 17:51   ` Greg KH
2021-04-07 20:12     ` Min Li
2021-04-08  6:36       ` Greg KH
2021-04-08 17:36         ` Min Li
2021-04-07 17:34 [PATCH net-next v2 1/2] mfd: " min.li.xe
2021-04-07 17:34 ` [PATCH net-next v2 2/2] misc: " min.li.xe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YG3weJsOd2IZ5jRQ@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=derek.kiernan@xilinx.com \
    --cc=dragan.cvetic@xilinx.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=min.li.xe@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).