From: Jarkko Sakkinen <jarkko@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-sgx@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] x86/sgx: Add sgx_nr_{all, free}_pages to the debugfs
Date: Thu, 8 Apr 2021 12:13:21 +0300 [thread overview]
Message-ID: <YG7JMc6b+HZIZqxM@kernel.org> (raw)
In-Reply-To: <YG7EWDXmwC9ai38k@kernel.org>
On Thu, Apr 08, 2021 at 11:52:40AM +0300, Jarkko Sakkinen wrote:
> On Wed, Apr 07, 2021 at 06:15:33PM +0200, Borislav Petkov wrote:
> > On Wed, Apr 07, 2021 at 07:09:11PM +0300, Jarkko Sakkinen wrote:
> > > I left out "epc" because they are already prefixed with "sgx_".
> >
> > Are there any other "page" types which are going to be figurating in
> > some pseudofs or is "sgx" == "epc" in this case?
> >
> > > debugfs was my first shot, but for sure these could be sysfs.
> >
> > Ok, let's keep it in debugfs for now, it can always be made an ABI later
> > and moved to sysfs. But pls document what those are and what they do and
> > that when in debugfs, there are no guarantees that these interfaces will
> > be there in the future.
>
> I think these attributes are quite useful information to have available so
> I'd go actually doing sysfs attributes and create
> Documentation/ABI/stable/sysfs-driver-sgx to document them.
>
> Given that they would go then to the sysfs directory of the driver, then
> probably the legit names for the attributes ought to be:
>
> - nr_all_epc_pages
> - nr_free_epc_pages
>
> What do you think?
Actually I think read-only sysctl attributes would be a better idea.
The rationale for this is that we have two misc devices sgx_enclave and
sgx_provision, and these are global attributes even applicable to KVM.
It does not matter functionality-wise, but API-wise it'd look stupid to
directly associate to sgx_enclave.
I.e. I'd add something along the lines of
static struct ctl_path x86_sysctl_path[] = {
{ .procname = "kernel", },
{ .procname = "x86", },
{ }
};
static struct ctl_table x86_sysctl_table[] = {
{
.procname = "sgx_nr_all_pages",
.mode = 0444,
/* rest ... */
},
{
.procname = "sgx_nr_free_pages",
.mode = 0444,
/* rest ... */
},
{ }
};
And write Documentation/x86/proc.rst.
/Jarkko
next prev parent reply other threads:[~2021-04-08 9:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 23:26 [PATCH v2 1/2] x86/sgx: Do not update sgx_nr_free_pages in sgx_setup_epc_section() Jarkko Sakkinen
2021-04-05 23:26 ` [PATCH v2 2/2] x86/sgx: Add sgx_nr_{all, free}_pages to the debugfs Jarkko Sakkinen
2021-04-07 15:56 ` Borislav Petkov
2021-04-07 16:09 ` Jarkko Sakkinen
2021-04-07 16:15 ` Borislav Petkov
2021-04-08 8:52 ` Jarkko Sakkinen
2021-04-08 9:01 ` Borislav Petkov
2021-04-08 9:13 ` Jarkko Sakkinen [this message]
2021-04-08 9:32 ` Borislav Petkov
2021-04-08 16:27 ` Jarkko Sakkinen
2021-04-07 15:49 ` [PATCH v2 1/2] x86/sgx: Do not update sgx_nr_free_pages in sgx_setup_epc_section() Borislav Petkov
2021-04-07 16:03 ` Jarkko Sakkinen
2021-04-07 16:18 ` Borislav Petkov
2021-04-08 8:48 ` Jarkko Sakkinen
2021-04-08 8:56 ` Borislav Petkov
2021-04-08 9:22 ` Jarkko Sakkinen
2021-04-08 9:29 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG7JMc6b+HZIZqxM@kernel.org \
--to=jarkko@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).