From: Daniel Vetter <daniel@ffwll.ch>
To: Huang Guobin <huangguobin4@huawei.com>
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] gma500: Use DEFINE_SPINLOCK() for spinlock
Date: Thu, 8 Apr 2021 13:20:19 +0200 [thread overview]
Message-ID: <YG7m8z5n223DqDht@phenom.ffwll.local> (raw)
In-Reply-To: <1617710114-48071-1-git-send-email-huangguobin4@huawei.com>
On Tue, Apr 06, 2021 at 07:55:14PM +0800, Huang Guobin wrote:
> From: Guobin Huang <huangguobin4@huawei.com>
>
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
Applied to drm-misc-next, thanks for your patch.
-Daniel
> ---
> drivers/gpu/drm/gma500/power.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/power.c b/drivers/gpu/drm/gma500/power.c
> index 56ef88237ef6..f07641dfa5a4 100644
> --- a/drivers/gpu/drm/gma500/power.c
> +++ b/drivers/gpu/drm/gma500/power.c
> @@ -36,7 +36,7 @@
> #include <linux/pm_runtime.h>
>
> static struct mutex power_mutex; /* Serialize power ops */
> -static spinlock_t power_ctrl_lock; /* Serialize power claim */
> +static DEFINE_SPINLOCK(power_ctrl_lock); /* Serialize power claim */
>
> /**
> * gma_power_init - initialise power manager
> @@ -55,7 +55,6 @@ void gma_power_init(struct drm_device *dev)
> dev_priv->display_power = true; /* We start active */
> dev_priv->display_count = 0; /* Currently no users */
> dev_priv->suspended = false; /* And not suspended */
> - spin_lock_init(&power_ctrl_lock);
> mutex_init(&power_mutex);
>
> if (dev_priv->ops->init_pm)
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2021-04-08 11:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 11:55 [PATCH -next] gma500: Use DEFINE_SPINLOCK() for spinlock Huang Guobin
2021-04-08 11:20 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG7m8z5n223DqDht@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=huangguobin4@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).