From: Jessica Yu <jeyu@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Evan Green <evgreen@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-doc@vger.kernel.org, Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces
Date: Thu, 8 Apr 2021 15:44:57 +0200 [thread overview]
Message-ID: <YG8I2dQWkOIkypqO@gunter> (raw)
In-Reply-To: <20210331030520.3816265-5-swboyd@chromium.org>
+++ Stephen Boyd [30/03/21 20:05 -0700]:
[snipped]
>diff --git a/kernel/module.c b/kernel/module.c
>index 30479355ab85..6f5bc1b046a5 100644
>--- a/kernel/module.c
>+++ b/kernel/module.c
>@@ -13,6 +13,7 @@
> #include <linux/trace_events.h>
> #include <linux/init.h>
> #include <linux/kallsyms.h>
>+#include <linux/buildid.h>
> #include <linux/file.h>
> #include <linux/fs.h>
> #include <linux/sysfs.h>
>@@ -2770,6 +2771,20 @@ static void add_kallsyms(struct module *mod, const struct load_info *info)
> }
> mod->core_kallsyms.num_symtab = ndst;
> }
>+
>+static void init_build_id(struct module *mod, const struct load_info *info)
>+{
>+ const Elf_Shdr *sechdr;
>+ unsigned int i;
>+
>+ for (i = 0; i < info->hdr->e_shnum; i++) {
>+ sechdr = &info->sechdrs[i];
>+ if (!sect_empty(sechdr) && sechdr->sh_type == SHT_NOTE &&
>+ !build_id_parse_buf((void *)sechdr->sh_addr, mod->build_id,
>+ sechdr->sh_size))
>+ break;
>+ }
>+}
Why not just look for the .note.gnu.build-id section instead of trying
to parse each note section? Doesn't it always contain the build id? At
least the ld man page seems to suggest this section name should be
consistent.
Jessica
next prev parent reply other threads:[~2021-04-08 13:45 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 3:05 [PATCH v3 00/12] Add build ID to stacktraces Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 01/12] buildid: Add API to parse build ID out of buffer Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 02/12] buildid: Stash away kernels build ID on init Stephen Boyd
2021-04-08 12:05 ` Jessica Yu
2021-04-08 18:52 ` Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 03/12] dump_stack: Add vmlinux build ID to stack traces Stephen Boyd
2021-04-07 13:42 ` Petr Mladek
2021-04-08 5:44 ` Stephen Boyd
2021-04-07 14:03 ` Petr Mladek
2021-04-08 1:14 ` Stephen Boyd
2021-04-08 6:20 ` Stephen Boyd
2021-04-08 10:13 ` Petr Mladek
2021-04-08 19:52 ` Stephen Boyd
2021-04-08 21:08 ` Stephen Boyd
2021-04-09 9:19 ` Petr Mladek
2021-03-31 3:05 ` [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces Stephen Boyd
2021-04-07 14:54 ` Petr Mladek
2021-04-07 15:07 ` Andy Shevchenko
2021-04-07 15:03 ` Petr Mladek
2021-04-07 15:37 ` Andy Shevchenko
2021-04-08 6:58 ` Stephen Boyd
2021-04-08 13:44 ` Jessica Yu [this message]
2021-04-08 14:05 ` Andy Shevchenko
2021-04-08 19:57 ` Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 05/12] arm64: stacktrace: Use %pSb for backtrace printing Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 06/12] x86/dumpstack: " Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 07/12] scripts/decode_stacktrace.sh: Support debuginfod Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 08/12] scripts/decode_stacktrace.sh: Silence stderr messages from addr2line/nm Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 09/12] scripts/decode_stacktrace.sh: Indicate 'auto' can be used for base path Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 10/12] buildid: Mark some arguments const Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 11/12] buildid: Fix kernel-doc notation Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 12/12] kdump: Use vmlinux_build_id to simplify Stephen Boyd
2021-04-07 17:03 ` Petr Mladek
2021-04-08 5:36 ` Stephen Boyd
2021-04-08 10:17 ` Baoquan He
2021-04-08 19:58 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG8I2dQWkOIkypqO@gunter \
--to=jeyu@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ast@kernel.org \
--cc=evgreen@chromium.org \
--cc=hsinyi@chromium.org \
--cc=jolsa@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=swboyd@chromium.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).