From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63DF0C43461 for ; Thu, 8 Apr 2021 15:18:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 304CE61108 for ; Thu, 8 Apr 2021 15:18:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232133AbhDHPSo (ORCPT ); Thu, 8 Apr 2021 11:18:44 -0400 Received: from mga18.intel.com ([134.134.136.126]:12959 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231863AbhDHPSn (ORCPT ); Thu, 8 Apr 2021 11:18:43 -0400 IronPort-SDR: uwv3zUhJX8P/oJJYaY1fyYfdA+SaE6ZTMb9um9Nyd+wTFY8RIPojpvv54Gr5CrV6fERwGWDfOB zSig7IAo363w== X-IronPort-AV: E=McAfee;i="6000,8403,9948"; a="181100255" X-IronPort-AV: E=Sophos;i="5.82,206,1613462400"; d="scan'208";a="181100255" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 08:18:27 -0700 IronPort-SDR: CN0TnCj9/GfHpXe0J91ryrKNLjRxO8VDVphFqV0GVR6NMENKY/CdBbEIcBbIIOP4v9cbAPMMPi wiXr70/7gf5w== X-IronPort-AV: E=Sophos;i="5.82,206,1613462400"; d="scan'208";a="397121016" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 08:18:24 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lUWQH-002Jst-EX; Thu, 08 Apr 2021 18:18:21 +0300 Date: Thu, 8 Apr 2021 18:18:21 +0300 From: Andy Shevchenko To: "Rafael J. Wysocki" Cc: Heikki Krogerus , Daniel Scally , Linux Kernel Mailing List , Linux Media Mailing List , ACPI Devel Maling List , Greg Kroah-Hartman , Yong Zhi , Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab Subject: Re: [PATCH v2 1/6] software node: Free resources explicitly when swnode_register() fails Message-ID: References: <20210329151207.36619-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 08, 2021 at 05:04:32PM +0200, Rafael J. Wysocki wrote: > On Thu, Apr 8, 2021 at 4:50 PM Andy Shevchenko > wrote: > > On Thu, Apr 08, 2021 at 04:15:37PM +0200, Rafael J. Wysocki wrote: > > > On Wed, Mar 31, 2021 at 1:06 PM Heikki Krogerus > > > wrote: > > > > > > > > On Mon, Mar 29, 2021 at 06:12:02PM +0300, Andy Shevchenko wrote: > > > > > Currently we have a slightly twisted logic in swnode_register(). > > > > > It frees resources that it doesn't allocate on error path and > > > > > in once case it relies on the ->release() implementation. > > > > > > > > > > Untwist the logic by freeing resources explicitly when swnode_register() > > > > > fails. Currently it happens only in fwnode_create_software_node(). > > > > > > > > > > Signed-off-by: Andy Shevchenko > > > > > > > > It all looks OK to me. FWIW, for the whole series: > > > > > > > > Reviewed-by: Heikki Krogerus > > > > > > Whole series applied (with some minor changelog edits) as 5.13 material, thanks! > > > > It seems Greg applied it already. Was it dropped there? > > Did he? > > OK, so please let me know if it's still there in the Greg's tree. Here [1] what I see. Seems still there. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?h=driver-core-next&id=6e11b376fd74356e32d842be588e12dc9bf6e197 -- With Best Regards, Andy Shevchenko