From: Jiri Olsa <jolsa@redhat.com>
To: "Bayduraev, Alexey V" <alexey.v.bayduraev@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Alexei Budankov <abudankov@huawei.com>,
Alexander Antonov <alexander.antonov@linux.intel.com>
Subject: Re: [PATCH v4 11/12] perf session: load data directory files for analysis
Date: Thu, 8 Apr 2021 23:52:52 +0200 [thread overview]
Message-ID: <YG97NIcSRyJcFSVY@krava> (raw)
In-Reply-To: <a0659ee9-d03c-38f4-dd8c-729efa98c525@linux.intel.com>
On Tue, Apr 06, 2021 at 11:52:32AM +0300, Bayduraev, Alexey V wrote:
>
> Introduce decompressor into trace reader object so that decompression
> could be executed on per data file basis separately for every data
> file located in data directory.
>
> Load data directory files and provide basic raw dump and aggregated
> analysis support of data directories in report mode, still with no
> memory consumption optimizations.
>
> Design and implementation are based on the prototype [1], [2].
>
> [1] git clone https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git -b perf/record_threads
> [2] https://lore.kernel.org/lkml/20180913125450.21342-1-jolsa@kernel.org/
>
> Suggested-by: Jiri Olsa <jolsa@kernel.org>
> Signed-off-by: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
hi,
this and following patch seem to squash several changes from
perf/record_threads:
21289ea28f2f perf session: Add reader return codes
44d19279d0e9 perf session: Add eof flag to reader state
490cece1ff49 perf session: Add reader__read_event function
ff9d91751367 perf session: Move head/file_offset computation into reader__mmap function
75a6af52ecae perf session: Move unmap into reader__mmap function
e1fc76225518 perf session: Add reader__mmap function
f7f0473104cd perf session: Add reader__init function
262c08cb7332 perf session: Move head in reader_state
fd91847190f0 perf session: Move data_size in reader_state
dcb49769bdde perf session: Move file_offset in reader_state
69c7f9557e83 perf session: Move file_pos in reader_state
c5c5c03f09f9 perf session: Add mmap_cur to reader_state
faf7b7176f2a perf session: Move mmap_idx in reader_state
42504d97a18f perf session: Move mmap_size in reader_state
7bf7ccdabc84 perf session: Move mmaps in reader_state
fc1eb45de565 perf session: Add path to reader object
making this a really big change of important code, which can't
be easily reviewed.. that's why I split it in the first place ;-)
I think we need to bring this code first with incremental changes
jirka
next prev parent reply other threads:[~2021-04-08 21:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 8:37 [PATCH v4 00/12] Introduce threaded trace streaming for basic perf record operation Bayduraev, Alexey V
2021-04-06 8:38 ` [PATCH v4 01/12] perf record: introduce thread affinity and mmap masks Bayduraev, Alexey V
2021-04-06 8:39 ` [PATCH v4 02/12] perf record: introduce thread specific data array Bayduraev, Alexey V
2021-04-08 14:16 ` Andi Kleen
2021-04-09 7:06 ` Bayduraev, Alexey V
2021-04-06 8:40 ` [PATCH v4 03/12] perf record: introduce thread local variable Bayduraev, Alexey V
2021-04-06 8:44 ` [PATCH v4 04/12] perf record: stop threads in the end of trace streaming Bayduraev, Alexey V
2021-04-06 8:45 ` [PATCH v4 05/12] perf record: start threads in the beginning " Bayduraev, Alexey V
2021-04-08 14:21 ` Andi Kleen
2021-04-06 8:47 ` [PATCH v4 06/12] perf record: introduce data file at mmap buffer object Bayduraev, Alexey V
2021-04-08 21:52 ` Jiri Olsa
2021-04-06 8:48 ` [PATCH v4 07/12] perf record: init " Bayduraev, Alexey V
2021-04-06 8:49 ` [PATCH v4 08/12] perf record: introduce --threads=<spec> command line option Bayduraev, Alexey V
2021-04-08 21:52 ` Jiri Olsa
2021-04-13 1:02 ` Namhyung Kim
2021-04-06 8:49 ` [PATCH v4 09/12] perf record: document parallel data streaming mode Bayduraev, Alexey V
2021-04-08 14:25 ` Andi Kleen
2021-04-06 8:51 ` [PATCH v4 10/12] perf report: output data file name in raw trace dump Bayduraev, Alexey V
2021-04-06 8:52 ` [PATCH v4 11/12] perf session: load data directory files for analysis Bayduraev, Alexey V
2021-04-08 21:52 ` Jiri Olsa [this message]
2021-04-06 8:53 ` [PATCH v4 12/12] perf session: use reader functions to load perf data file Bayduraev, Alexey V
2021-04-08 14:26 ` Andi Kleen
2021-04-08 21:52 ` [PATCH v4 00/12] Introduce threaded trace streaming for basic perf record operation Jiri Olsa
2021-04-09 10:51 ` Bayduraev, Alexey V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG97NIcSRyJcFSVY@krava \
--to=jolsa@redhat.com \
--cc=abudankov@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.antonov@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.v.bayduraev@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).