From: Petr Mladek <pmladek@suse.com>
To: Wang Qing <wangqing@vivo.com>
Cc: Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Guilherme G. Piccoli" <gpiccoli@canonical.com>,
Vlastimil Babka <vbabka@suse.cz>,
Santosh Sivaraj <santosh@fossix.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] workqueue/watchdog: Make unbound workqueues aware of
Date: Mon, 29 Mar 2021 12:14:03 +0200 [thread overview]
Message-ID: <YGGoa/AAk86FmYgn@alley> (raw)
In-Reply-To: <1616585643-26720-1-git-send-email-wangqing@vivo.com>
On Wed 2021-03-24 19:34:02, Wang Qing wrote:
> There are two workqueue-specific watchdog timestamps:
>
> + @wq_watchdog_touched_cpu (per-CPU) updated by
> touch_softlockup_watchdog()
>
> + @wq_watchdog_touched (global) updated by
> touch_all_softlockup_watchdogs()
>
> watchdog_timer_fn() checks only the global @wq_watchdog_touched for
> unbound workqueues. As a result, unbound workqueues are not aware
> of touch_softlockup_watchdog(). The watchdog might report a stall
> even when the unbound workqueues are blocked by a known slow code.
>
> Solution:
> touch_softlockup_watchdog() must touch also the global @wq_watchdog_touched
> timestamp.
>
> The global timestamp can not longer be used for bound workqueues
> because it is updated on all CPUs. Instead, bound workqueues
> have to check only @wq_watchdog_touched_cpu and these timestamp
> has to be updated for all CPUs in touch_all_softlockup_watchdogs().
>
> Beware:
> The change might cause the opposite problem. An unbound workqueue
> might get blocked on CPU A because of a real softlockup. The workqueue
> watchdog would miss it when the timestamp got touched on CPU B.
>
> It is acceptable because softlockups are detected by softlockup
> watchdog. The workqueue watchdog is there to detect stalls where
> a work never finishes, for example, because of dependencies of works
> queued into the same workqueue.
>
> V3:
> - Modify the commit message clearly according to Petr's suggestion.
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
The patch fixes a real problem:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
prev parent reply other threads:[~2021-03-29 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 11:34 [PATCH V3] workqueue/watchdog: Make unbound workqueues aware of Wang Qing
2021-03-29 10:14 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGGoa/AAk86FmYgn@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=gpiccoli@canonical.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=santosh@fossix.org \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).