From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5BCEC43461 for ; Thu, 1 Apr 2021 02:20:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABDDE61077 for ; Thu, 1 Apr 2021 02:20:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233076AbhDACTu (ORCPT ); Wed, 31 Mar 2021 22:19:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232672AbhDACTP (ORCPT ); Wed, 31 Mar 2021 22:19:15 -0400 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA267C061574; Wed, 31 Mar 2021 19:19:15 -0700 (PDT) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94 #2 (Red Hat Linux)) id 1lRmvQ-001X5H-Kb; Thu, 01 Apr 2021 02:19:12 +0000 Date: Thu, 1 Apr 2021 02:19:12 +0000 From: Al Viro To: Jonathan Corbet Cc: Randy Dunlap , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 1/2] fs/namespace: corrent/improve kernel-doc notation Message-ID: References: <20210318025227.4162-1-rdunlap@infradead.org> <87r1jvjclp.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r1jvjclp.fsf@meer.lwn.net> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 31, 2021 at 02:24:18PM -0600, Jonathan Corbet wrote: > Randy Dunlap writes: > > > Fix kernel-doc warnings in fs/namespace.c: > > > > ./fs/namespace.c:1379: warning: Function parameter or member 'm' not described in 'may_umount_tree' > > ./fs/namespace.c:1379: warning: Excess function parameter 'mnt' description in 'may_umount_tree' > > ./fs/namespace.c:1950: warning: Function parameter or member 'path' not described in 'clone_private_mount' > > > > Also convert path_is_mountpoint() comments to kernel-doc. > > > > Signed-off-by: Randy Dunlap > > Cc: Al Viro > > Cc: Jonathan Corbet > > Cc: linux-doc@vger.kernel.org > > --- > > Jon, Al has OK-ed you to merge this patch (and the next one, please). > > > > fs/namespace.c | 14 ++++++++------ > > 1 file changed, 8 insertions(+), 6 deletions(-) > > An actual acked-by would have been nice, oh well. Meanwhile, I've > applied them with fixes to the typos in both changelogs :) Generally speaking, I'm only glad to leave handling kernel-doc patches to somebody else, especially when they are that trivial ;-) Anyway, Acked-by: Al Viro