From: Danilo Krummrich <danilokrummrich@dk-develop.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
davem@davemloft.net, hkallweit1@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jeremy.linton@arm.com
Subject: Re: [PATCH 2/2] net: mdio: support c45 peripherals on c22 busses
Date: Tue, 6 Apr 2021 00:30:08 +0200 [thread overview]
Message-ID: <YGuPcNPXiQZkEehh@arch-linux> (raw)
In-Reply-To: <YGtksD5p5JVpnazu@lunn.ch>
On Mon, Apr 05, 2021 at 09:27:44PM +0200, Andrew Lunn wrote:
> > Now, instead of encoding this information of the bus' capabilities at both
> > places, I'd propose just checking the mii_bus->capabilities field in the
> > mdiobus_c45_*() functions. IMHO this would be a little cleaner, than having two
> > places where this information is stored. What do you think about that?
>
> You will need to review all the MDIO bus drivers to make sure they
> correctly set the capabilities. There is something like 55 using
> of_mdiobus_register() and 45 using mdiobus_register(). So you have 100
> drivers to review.
Yes, but I think it would be enough to look at the drivers handling the
MII_ADDR_C45 flag, because those are either
- actually capable to do C45 bus transfers or
- do properly return -EOPNOTSUPP.
I counted 27 drivers handling the MII_ADDR_C45 flag. Setting the capabilities
for those should be pretty easy.
The remaining ones, which should be about 73 then, could be left untouched,
because the default capability MDIOBUS_NO_CAP would indicate they can C22 only.
Since they don't handle the MII_ADDR_C45 flag at all, this should be the
correct assumption.
>
> Andrew
>
next prev parent reply other threads:[~2021-04-05 22:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 14:17 net: mdio: support c45 peripherals on c22 only capable mdio controllers Danilo Krummrich
2021-03-31 14:17 ` [PATCH 1/2] net: mdio: rename mii bus probe_capabilities Danilo Krummrich
2021-03-31 14:17 ` [PATCH 2/2] net: mdio: support c45 peripherals on c22 busses Danilo Krummrich
2021-03-31 16:27 ` Andrew Lunn
2021-03-31 17:58 ` danilokrummrich
2021-03-31 18:35 ` Russell King - ARM Linux admin
2021-04-01 1:23 ` danilokrummrich
2021-04-01 8:48 ` Russell King - ARM Linux admin
2021-04-02 1:10 ` Danilo Krummrich
2021-04-02 12:28 ` Andrew Lunn
2021-04-04 18:25 ` Danilo Krummrich
2022-02-08 16:30 ` Geert Uytterhoeven
2022-02-08 22:52 ` Danilo Krummrich
2021-04-02 12:58 ` Russell King - ARM Linux admin
2021-04-04 19:23 ` Danilo Krummrich
2021-04-05 13:33 ` Andrew Lunn
2021-04-05 18:58 ` Danilo Krummrich
2021-04-05 19:27 ` Andrew Lunn
2021-04-05 22:30 ` Danilo Krummrich [this message]
2021-04-06 7:21 ` Danilo Krummrich
2021-04-05 21:12 ` Russell King - ARM Linux admin
2021-04-07 13:26 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGuPcNPXiQZkEehh@arch-linux \
--to=danilokrummrich@dk-develop.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=jeremy.linton@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).