From: Greg KH <gregkh@linuxfoundation.org>
To: dillon.minfei@gmail.com
Cc: jirislaby@kernel.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, linux-serial@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: stm32: optimize spin lock usage
Date: Mon, 12 Apr 2021 07:52:24 +0200 [thread overview]
Message-ID: <YHPgGI6EmTzmVH7g@kroah.com> (raw)
In-Reply-To: <1618202061-8243-1-git-send-email-dillon.minfei@gmail.com>
On Mon, Apr 12, 2021 at 12:34:21PM +0800, dillon.minfei@gmail.com wrote:
> From: dillon min <dillon.minfei@gmail.com>
>
> To avoid potential deadlock in spin_lock usage, change to use
> spin_lock_irqsave(), spin_unlock_irqrestore() in process(thread_fn) context.
> spin_lock(), spin_unlock() under handler context.
>
> remove unused local_irq_save/restore call.
>
> Signed-off-by: dillon min <dillon.minfei@gmail.com>
> ---
> Was verified on stm32f469-disco board. need more test on stm32mp platform.
>
> drivers/tty/serial/stm32-usart.c | 27 +++++++++++++++++----------
> 1 file changed, 17 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
> index b3675cf25a69..c4c859b34367 100644
> --- a/drivers/tty/serial/stm32-usart.c
> +++ b/drivers/tty/serial/stm32-usart.c
> @@ -214,7 +214,7 @@ static void stm32_usart_receive_chars(struct uart_port *port, bool threaded)
> struct tty_port *tport = &port->state->port;
> struct stm32_port *stm32_port = to_stm32_port(port);
> const struct stm32_usart_offsets *ofs = &stm32_port->info->ofs;
> - unsigned long c;
> + unsigned long c, flags;
> u32 sr;
> char flag;
>
> @@ -276,9 +276,17 @@ static void stm32_usart_receive_chars(struct uart_port *port, bool threaded)
> uart_insert_char(port, sr, USART_SR_ORE, c, flag);
> }
>
> - spin_unlock(&port->lock);
> + if (threaded)
> + spin_unlock_irqrestore(&port->lock, flags);
> + else
> + spin_unlock(&port->lock);
You shouldn't have to check for this, see the other patches on the list
recently that fixed this up to not be an issue for irq handlers.
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-12 5:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 4:34 [PATCH] serial: stm32: optimize spin lock usage dillon.minfei
2021-04-12 5:52 ` Greg KH [this message]
2021-04-12 6:50 ` dillon min
2021-04-12 8:25 ` Greg KH
2021-04-12 8:54 ` dillon min
2021-04-12 13:19 ` [Linux-stm32] " Erwan LE RAY
2021-04-12 13:41 ` dillon min
2021-04-12 7:23 ` kernel test robot
2021-04-12 7:29 ` dillon min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHPgGI6EmTzmVH7g@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexandre.torgue@foss.st.com \
--cc=dillon.minfei@gmail.com \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).