From: Greg KH <gregkh@linuxfoundation.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Mitali Borkar <mitaliborkar810@gmail.com>,
bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com,
mitali_s@me.iitr.ac.in
Subject: Re: [PATCH 1/6] staging: media: intel-ipu3: replace bit shifts with BIT() macro
Date: Mon, 12 Apr 2021 11:49:43 +0200 [thread overview]
Message-ID: <YHQXty07oAP1L0W9@kroah.com> (raw)
In-Reply-To: <20210412094230.GI3@paasikivi.fi.intel.com>
On Mon, Apr 12, 2021 at 12:42:30PM +0300, Sakari Ailus wrote:
> Hi Mitali,
>
> On Mon, Apr 12, 2021 at 04:38:39AM +0530, Mitali Borkar wrote:
> > Added #include <linux/bitops.h> and replaced bit shifts by BIT() macro.
> > This BIT() macro from linux/bitops.h is used to define IPU3_UAPI_GRID_Y_START_EN
> > and IPU3_UAPI_AWB_RGBS_THR_B_* bitmask.
> > Use of macro is better and neater. It maintains consistency.
> > Reported by checkpatch.
> >
> > Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> > ---
> > drivers/staging/media/ipu3/include/intel-ipu3.h | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/media/ipu3/include/intel-ipu3.h b/drivers/staging/media/ipu3/include/intel-ipu3.h
> > index edd8edda0647..589d5ccee3a7 100644
> > --- a/drivers/staging/media/ipu3/include/intel-ipu3.h
> > +++ b/drivers/staging/media/ipu3/include/intel-ipu3.h
> > @@ -5,6 +5,7 @@
> > #define __IPU3_UAPI_H
> >
> > #include <linux/types.h>
> > +#include <linux/bitops.h>
> >
> > /* from /drivers/staging/media/ipu3/include/videodev2.h */
> >
> > @@ -22,11 +23,11 @@
> > #define IPU3_UAPI_MAX_BUBBLE_SIZE 10
> >
> > #define IPU3_UAPI_GRID_START_MASK ((1 << 12) - 1)
> > -#define IPU3_UAPI_GRID_Y_START_EN (1 << 15)
> > +#define IPU3_UAPI_GRID_Y_START_EN BIT(15)
>
> This header is used in user space where you don't have the BIT() macro.
If that is true, why is it not in a "uapi" subdir within this driver?
Otherwise it is not obvious at all that this is the case :(
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-12 9:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1618180659.git.mitaliborkar810@gmail.com>
2021-04-11 23:08 ` [PATCH 1/6] staging: media: intel-ipu3: replace bit shifts with BIT() macro Mitali Borkar
2021-04-12 9:42 ` Sakari Ailus
2021-04-12 9:49 ` Greg KH [this message]
2021-04-12 10:17 ` [Outreachy kernel] " Julia Lawall
2021-04-12 10:44 ` Sakari Ailus
2021-04-12 10:55 ` Greg KH
2021-04-12 11:00 ` Sakari Ailus
2021-04-11 23:08 ` [PATCH 2/6] staging: media: intel-ipu3: preferred __aligned(size) over __attribute__aligned(size) Mitali Borkar
2021-04-12 9:43 ` Sakari Ailus
2021-04-12 14:29 ` [Outreachy kernel] " Mitali Borkar
2021-04-12 21:22 ` Sakari Ailus
2021-04-13 7:40 ` David Laight
2021-04-13 9:56 ` sakari.ailus
2021-04-13 10:32 ` David Laight
2021-04-11 23:09 ` [PATCH 3/6] staging: media: intel-ipu3: remove unnecessary blank line Mitali Borkar
2021-04-11 23:09 ` [PATCH 4/6] staging: media: intel-ipu3: reduce length of line Mitali Borkar
2021-04-11 23:09 ` [PATCH 5/6] staging: media: intel-ipu3: line should not end with '[' Mitali Borkar
2021-04-12 9:49 ` Sakari Ailus
2021-04-11 23:10 ` [PATCH 6/6] staging: media: intel-ipu3: remove space before tabs Mitali Borkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHQXty07oAP1L0W9@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bingbu.cao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mitali_s@me.iitr.ac.in \
--cc=mitaliborkar810@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).