linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] USB: Add LPM quirk for Lenovo ThinkPad USB-C Dock Gen2 Ethernet
@ 2021-04-12 12:37 Kai-Heng Feng
  2021-04-12 12:47 ` Johan Hovold
  0 siblings, 1 reply; 2+ messages in thread
From: Kai-Heng Feng @ 2021-04-12 12:37 UTC (permalink / raw)
  To: gregkh
  Cc: Kai-Heng Feng, Alan Stern, penghao, Stefan Ursella, Kars Mulder,
	Oliver Neukum, Tomasz Meresiński, Johan Hovold,
	open list:USB SUBSYSTEM, open list

This is another branded 8153 device that doesn't work well with LPM
enabled:
[ 400.597506] r8152 5-1.1:1.0 enx482ae3a2a6f0: Tx status -71

So disable LPM to resolve the issue.
BugLink: https://bugs.launchpad.net/bugs/1922651

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 76ac5d6555ae..dfedb51cf832 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -434,6 +434,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	{ USB_DEVICE(0x1532, 0x0116), .driver_info =
 			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
 
+	/* Lenovo ThinkPad USB-C Dock Gen2 Ethernet (RTL8153 GigE) */
+	{ USB_DEVICE(0x17ef, 0xa387), .driver_info = USB_QUIRK_NO_LPM },
+
 	/* Lenovo ThinkCenter A630Z TI024Gen3 usb-audio */
 	{ USB_DEVICE(0x17ef, 0xa012), .driver_info =
 			USB_QUIRK_DISCONNECT_SUSPEND },
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] USB: Add LPM quirk for Lenovo ThinkPad USB-C Dock Gen2 Ethernet
  2021-04-12 12:37 [PATCH] USB: Add LPM quirk for Lenovo ThinkPad USB-C Dock Gen2 Ethernet Kai-Heng Feng
@ 2021-04-12 12:47 ` Johan Hovold
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2021-04-12 12:47 UTC (permalink / raw)
  To: Kai-Heng Feng
  Cc: gregkh, Alan Stern, penghao, Stefan Ursella, Kars Mulder,
	Oliver Neukum, Tomasz Meresiński, open list:USB SUBSYSTEM,
	open list

On Mon, Apr 12, 2021 at 08:37:52PM +0800, Kai-Heng Feng wrote:
> This is another branded 8153 device that doesn't work well with LPM
> enabled:
> [ 400.597506] r8152 5-1.1:1.0 enx482ae3a2a6f0: Tx status -71
> 
> So disable LPM to resolve the issue.
> BugLink: https://bugs.launchpad.net/bugs/1922651
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>  drivers/usb/core/quirks.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 76ac5d6555ae..dfedb51cf832 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -434,6 +434,9 @@ static const struct usb_device_id usb_quirk_list[] = {
>  	{ USB_DEVICE(0x1532, 0x0116), .driver_info =
>  			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
>  
> +	/* Lenovo ThinkPad USB-C Dock Gen2 Ethernet (RTL8153 GigE) */
> +	{ USB_DEVICE(0x17ef, 0xa387), .driver_info = USB_QUIRK_NO_LPM },
> +
>  	/* Lenovo ThinkCenter A630Z TI024Gen3 usb-audio */
>  	{ USB_DEVICE(0x17ef, 0xa012), .driver_info =
>  			USB_QUIRK_DISCONNECT_SUSPEND },

Please keep the entries sorted by VID/PID.

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-12 12:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-12 12:37 [PATCH] USB: Add LPM quirk for Lenovo ThinkPad USB-C Dock Gen2 Ethernet Kai-Heng Feng
2021-04-12 12:47 ` Johan Hovold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).