From: Leon Romanovsky <leon@kernel.org>
To: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: Narendra K <narendra_k@dell.com>,
Viktor Mihajlovski <mihajlov@linux.ibm.com>,
Stefan Raspl <raspl@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
linux-netdev@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 0/1] Use of /sys/bus/pci/devices/…/index for non-SMBIOS platforms
Date: Tue, 13 Apr 2021 08:39:25 +0300 [thread overview]
Message-ID: <YHUujU1o6bdHDfmS@unreal> (raw)
In-Reply-To: <20210412135905.1434249-1-schnelle@linux.ibm.com>
On Mon, Apr 12, 2021 at 03:59:04PM +0200, Niklas Schnelle wrote:
> Hi Narendra, Hi All,
>
> According to Documentation/ABI/testing/sysfs-bus-pci you are responsible
> for the index device attribute that is used by systemd to create network
> interface names.
>
> Now we would like to reuse this attribute for firmware provided PCI
> device index numbers on the s390 architecture which doesn't have
> SMBIOS/DMI nor ACPI. All code changes are within our architecture
> specific code but I'd like to get some Acks for this reuse. I've sent an
> RFC version of this patch on 15th of March with the subject:
>
> s390/pci: expose a PCI device's UID as its index
>
> but got no response. Would it be okay to re-use this attribute for
> essentially the same purpose but with index numbers provided by
> a different platform mechanism? I think this would be cleaner than
> further proliferation of /sys/bus/pci/devices/<dev>/xyz_index
> attributes and allows re-use of the existing userspace infrastructure.
I'm missing an explanation that this change is safe for systemd and
they don't have some hard-coded assumption about the meaning of existing
index on s390.
Thanks
next prev parent reply other threads:[~2021-04-13 5:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 13:59 [PATCH 0/1] Use of /sys/bus/pci/devices/…/index for non-SMBIOS platforms Niklas Schnelle
2021-04-12 13:59 ` [PATCH 1/1] s390/pci: expose a PCI device's UID as its index Niklas Schnelle
2021-04-14 20:17 ` Bjorn Helgaas
2021-04-15 7:24 ` Niklas Schnelle
2021-04-16 17:58 ` K, Narendra
2021-04-17 10:47 ` Viktor Mihajlovski
2021-04-18 8:18 ` K, Narendra
2021-04-13 5:39 ` Leon Romanovsky [this message]
2021-04-13 6:57 ` [PATCH 0/1] Use of /sys/bus/pci/devices/…/index for non-SMBIOS platforms Niklas Schnelle
2021-04-13 7:32 ` Leon Romanovsky
2021-04-13 7:53 ` Niklas Schnelle
2021-04-13 18:22 ` K, Narendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHUujU1o6bdHDfmS@unreal \
--to=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-netdev@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mihajlov@linux.ibm.com \
--cc=narendra_k@dell.com \
--cc=oberpar@linux.ibm.com \
--cc=raspl@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).