From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5118DC433B4 for ; Tue, 13 Apr 2021 16:16:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 200C36128E for ; Tue, 13 Apr 2021 16:16:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239645AbhDMQRP (ORCPT ); Tue, 13 Apr 2021 12:17:15 -0400 Received: from mga17.intel.com ([192.55.52.151]:50326 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229776AbhDMQRN (ORCPT ); Tue, 13 Apr 2021 12:17:13 -0400 IronPort-SDR: r8m9em0NkVXxo5RcGBdGd0vmeSau9gh7sEjDnI38b383ogy3m6imq0MsExrACLyuRMvhNWi2fm AE9IsXnJAM/A== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="174547165" X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="174547165" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 09:10:33 -0700 IronPort-SDR: ru4crNMreHoXQpsxGuzZMkdEosvf9+r3cFUPGuvreADT9tP6nftbq1raPDbxxsb2etlBCuEIfz E+6gqYoUayfg== X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="452019778" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 09:10:25 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lWLcM-003nnM-Az; Tue, 13 Apr 2021 19:10:22 +0300 Date: Tue, 13 Apr 2021 19:10:22 +0300 From: Andy Shevchenko To: Daniel Scally Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Yong Zhi , Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab Subject: Re: [PATCH v1 1/1] media: ipu3-cio2: Fix referece counting when looping over ACPI devices Message-ID: References: <20210404181409.1451026-1-andy.shevchenko@gmail.com> <1ab48622-be85-f1d7-caa4-8b04a4727d5d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ab48622-be85-f1d7-caa4-8b04a4727d5d@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 05, 2021 at 09:37:28PM +0100, Daniel Scally wrote: > On 04/04/2021 19:14, Andy Shevchenko wrote: > > When we continue, due to device is disabled, loop we have to drop reference count. > > When we have an array full of devices we have to also drop the reference count. > > Note, in this case the cio2_bridge_unregister_sensors() is called by the caller. > > > > Fixes: 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver") > > Cc: Daniel Scally > > Cc: Sakari Ailus > > Signed-off-by: Andy Shevchenko > > Ah; thanks for catching those, I'm annoyed to have missed the > acpi_dev_put() calls in particular > > Reviewed-by: Daniel Scally Sakari, Mauro, can this be applied as v5.12 material, please? -- With Best Regards, Andy Shevchenko