From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4645C433B4 for ; Wed, 14 Apr 2021 19:38:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A889561166 for ; Wed, 14 Apr 2021 19:38:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235047AbhDNTjI (ORCPT ); Wed, 14 Apr 2021 15:39:08 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:51354 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235025AbhDNTjC (ORCPT ); Wed, 14 Apr 2021 15:39:02 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lWlLO-00Gkg9-U8; Wed, 14 Apr 2021 21:38:34 +0200 Date: Wed, 14 Apr 2021 21:38:34 +0200 From: Andrew Lunn To: Thomas Bogendoerfer Cc: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/7] net: korina: Use devres functions Message-ID: References: <20210413204818.23350-1-tsbogend@alpha.franken.de> <20210413204818.23350-3-tsbogend@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210413204818.23350-3-tsbogend@alpha.franken.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + if (!p) { > printk(KERN_ERR DRV_NAME ": cannot remap registers\n"); > - rc = -ENXIO; > - goto probe_err_out; > + return -ENOMEM; > } Hi Thomas Another possible cleanup would be replacing printk(KERN_ERR with dev_err(), or netdev_err() etc. Andrew