From: Joerg Roedel <joro@8bytes.org>
To: Yong Wu <yong.wu@mediatek.com>
Cc: Will Deacon <will@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Tomasz Figa <tfiga@chromium.org>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org,
Krzysztof Kozlowski <krzk@kernel.org>,
youlin.pei@mediatek.com, anan.sun@mediatek.com,
chao.hao@mediatek.com, Valdis Kletnieks <valdis.kletnieks@vt.edu>
Subject: Re: [PATCH 1/2] iommu/mediatek-v1: Avoid build fail when build as module
Date: Thu, 15 Apr 2021 15:48:38 +0200 [thread overview]
Message-ID: <YHhENs5Jh5h0Pz+r@8bytes.org> (raw)
In-Reply-To: <20210412064843.11614-1-yong.wu@mediatek.com>
On Mon, Apr 12, 2021 at 02:48:42PM +0800, Yong Wu wrote:
> When this driver build as module, It build fail like:
>
> ERROR: modpost: "of_phandle_iterator_args"
> [drivers/iommu/mtk_iommu_v1.ko] undefined!
>
> This patch remove this interface to avoid this build fail.
>
> Reported-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> Currently below patch is only in linux-next-20210409. This fixes tag may be
> not needed. we can add this if it is need.
> Fixes: 8de000cf0265 ("iommu/mediatek-v1: Allow building as module")
> ---
> drivers/iommu/mtk_iommu_v1.c | 62 ++++++++++++++++--------------------
> 1 file changed, 28 insertions(+), 34 deletions(-)
Applied both, thanks.
prev parent reply other threads:[~2021-04-15 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 6:48 [PATCH 1/2] iommu/mediatek-v1: Avoid build fail when build as module Yong Wu
2021-04-12 6:48 ` [PATCH 2/2] iommu/mediatek-v1: Add error handle for mtk_iommu_probe Yong Wu
2021-04-15 13:48 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHhENs5Jh5h0Pz+r@8bytes.org \
--to=joro@8bytes.org \
--cc=anan.sun@mediatek.com \
--cc=chao.hao@mediatek.com \
--cc=iommu@lists.linux-foundation.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=valdis.kletnieks@vt.edu \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).