From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74003C43470 for ; Sat, 17 Apr 2021 16:40:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53EA56120F for ; Sat, 17 Apr 2021 16:40:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236683AbhDQQlL (ORCPT ); Sat, 17 Apr 2021 12:41:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236665AbhDQQlK (ORCPT ); Sat, 17 Apr 2021 12:41:10 -0400 Received: from mail.pqgruber.com (mail.pqgruber.com [IPv6:2a05:d014:575:f70b:4f2c:8f1d:40c4:b13e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56DC0C061574; Sat, 17 Apr 2021 09:40:43 -0700 (PDT) Received: from workstation.tuxnet (213-47-165-233.cable.dynamic.surfer.at [213.47.165.233]) by mail.pqgruber.com (Postfix) with ESMTPSA id 9F41CC725D8; Sat, 17 Apr 2021 18:40:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pqgruber.com; s=mail; t=1618677641; bh=RmhXOMCFFCbce605ZIbZPj9mHR2sZMVr+GIMZbzQjv8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IPxU1qS2JQXMzTWtfWiwsM7n21Ahu6UzIOMp2QGzj9UAPQwRduji1PDlM2rNt6nOj ms8PbzKUgjXC2Xz8zKDfVN4KKxG+7ESy73YaG/4r3PPmOvldfZIw+OD5GDuhJXXnD1 21oosYNzdL/xumg3nPoCbxYYw58F7iokMJUP6jiw= Date: Sat, 17 Apr 2021 18:40:40 +0200 From: Clemens Gruber To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-pwm@vger.kernel.org, Thierry Reding , Sven Van Asbroeck , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 1/8] pwm: pca9685: Switch to atomic API Message-ID: References: <20210412132745.76609-1-clemens.gruber@pqgruber.com> <20210417153728.eohhphmtm6qf26y4@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210417153728.eohhphmtm6qf26y4@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sat, Apr 17, 2021 at 05:37:28PM +0200, Uwe Kleine-König wrote: > On Mon, Apr 12, 2021 at 03:27:38PM +0200, Clemens Gruber wrote: > > The switch to the atomic API goes hand in hand with a few fixes to > > previously experienced issues: > > - The duty cycle is no longer lost after disable/enable (previously the > > OFF registers were cleared in disable and the user was required to > > call config to restore the duty cycle settings) > > - If one sets a period resulting in the same prescale register value, > > the sleep and write to the register is now skipped > > - Previously, only the full ON bit was toggled in GPIO mode (and full > > OFF cleared if set to high), which could result in both full OFF and > > full ON not being set and on=0, off=0, which is not allowed according > > to the datasheet > > - The OFF registers were reset to 0 in probe, which could lead to the > > forbidden on=0, off=0. Fixed by resetting to POR default (full OFF) > > I didn't recheck all details, but the patch is definitively an > improvement, so: > > Acked-by: Uwe Kleine-König Thanks, but there is a newer version v9, I assume your acks are meant for the newer one? Clemens