From: Ashish Kalra <eashishkalra@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ashish Kalra <eashishkalra@gmail.com>,
Ivan Safonov <insafonov@gmail.com>,
Abheek Dhawan <adawesomeguy222@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Waiman Long <longman@redhat.com>,
Pritthijit Nath <pritthijit.nath@icloud.com>,
Allen Pais <apais@linux.microsoft.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces)
Date: Sat, 1 May 2021 17:09:28 +0530 [thread overview]
Message-ID: <YI098DQNtK3i2Fge@ashish-NUC8i5BEH> (raw)
Currently p80211knetdev_do_ioctl use type casting to req->data to prevent sparse warning while calling memdup_user, instead of type casting it here, its better to change data type for data inside p80211ioctl_req to include __user.
Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
---
Changes from v1:
removed type casting of (void __user *) for req->data and corrected type for data to include __user.
drivers/staging/wlan-ng/p80211ioctl.h | 2 +-
drivers/staging/wlan-ng/p80211netdev.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211ioctl.h b/drivers/staging/wlan-ng/p80211ioctl.h
index ed65ac57adbe..77e8d2913b76 100644
--- a/drivers/staging/wlan-ng/p80211ioctl.h
+++ b/drivers/staging/wlan-ng/p80211ioctl.h
@@ -81,7 +81,7 @@
struct p80211ioctl_req {
char name[WLAN_DEVNAMELEN_MAX];
- caddr_t data;
+ char __user *data;
u32 magic;
u16 len;
u32 result;
diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
index 70570e8a5ad2..dfb2d2832830 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -569,7 +569,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
goto bail;
}
- msgbuf = memdup_user((void __user *)req->data, req->len);
+ msgbuf = memdup_user(req->data, req->len);
if (IS_ERR(msgbuf)) {
result = PTR_ERR(msgbuf);
goto bail;
@@ -579,7 +579,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
if (result == 0) {
if (copy_to_user
- ((void __user *)req->data, msgbuf, req->len)) {
+ (req->data, msgbuf, req->len)) {
result = -EFAULT;
}
}
--
2.30.2
next reply other threads:[~2021-05-01 11:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 11:39 Ashish Kalra [this message]
2021-05-01 12:23 ` [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) Greg Kroah-Hartman
2021-05-01 13:54 ` Ashish
-- strict thread matches above, loose matches on Subject: below --
2021-04-27 18:03 Ashish Kalra
2021-04-27 17:22 Ashish Kalra
2021-04-27 16:58 Ashish Kalra
2021-04-28 6:02 ` Greg Kroah-Hartman
2021-04-27 18:04 ` ashish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YI098DQNtK3i2Fge@ashish-NUC8i5BEH \
--to=eashishkalra@gmail.com \
--cc=adawesomeguy222@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apais@linux.microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=insafonov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=longman@redhat.com \
--cc=pritthijit.nath@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).